Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release): package.json publish config non-public #753 #754

Merged
merged 1 commit into from
Apr 1, 2021

Conversation

petermetz
Copy link
Contributor

Several packages were missing the publish configuration
from their package.json files which made them private
packages on npm by default.
I fixed the visibility manually via npm GUI but we still need
to update the package.json files to match that in version
control as well so here we go.

Fixes #753

Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com

…i#753

Several packages were missing the publish configuration
from their package.json files which made them private
packages on npm by default.
I fixed the visibility manually via npm GUI but we still need
to update the package.json files to match that in version
control as well so here we go.

Fixes hyperledger-cacti#753

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz added bug Something isn't working dependencies Pull requests that update a dependency file labels Mar 30, 2021
Copy link
Contributor

@jonathan-m-hamilton jonathan-m-hamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petermetz petermetz merged commit 5a1b7a6 into hyperledger-cacti:main Apr 1, 2021
@petermetz petermetz deleted the fix-753 branch April 1, 2021 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(release): package.json publish config non-public
3 participants