Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): dependent issues bot workflow has no job id #848 #849

Merged
merged 1 commit into from
Apr 27, 2021

Conversation

petermetz
Copy link
Contributor

@petermetz petermetz commented Apr 23, 2021

There's a mismatch in what you have set as the name of the required status check for the main branch (Dependabot Issues) and what the check is actually called when the workflow runs (check)

https://github.com/hyperledger/cactus/actions/runs/772009240/workflow

jobs:
  check:
    runs-on: ubuntu-latest
---

You can rename the job in that workflow to Dependabot Issues to match the required status check name:

jobs:
  check:
    runs-on: ubuntu-latest
    name: Dependabot Issues
----

https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idname

The check will then be displayed as Dependabot Issues - if this was the intended name - and will satisfy the protected branches rule.

Fixes #848

Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com

@petermetz petermetz added the bug Something isn't working label Apr 23, 2021
…i#848

There's a mismatch in what you have set as the name of the required status check for the main branch (Dependabot Issues) and what the check is actually called when the workflow runs (check)

https://github.com/hyperledger/cactus/actions/runs/772009240/workflow

```yaml
jobs:
  check:
    runs-on: ubuntu-latest
---
```

You can rename the job in that workflow to Dependabot Issues to match the required status check name:

```yaml
jobs:
  check:
    runs-on: ubuntu-latest
    name: Dependabot Issues
----
```
https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idname

The check will then be displayed as Dependabot Issues - if this was the intended name - and will satisfy the protected branches rule.

Fixes hyperledger-cacti#848

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Copy link
Contributor

@jonathan-m-hamilton jonathan-m-hamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petermetz petermetz merged commit af61202 into hyperledger-cacti:main Apr 27, 2021
@petermetz petermetz deleted the fix-848 branch April 27, 2021 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(ci): dependent issues bot workflow has no job id
3 participants