-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(aws-sm): added keychain plugin for aws secret manager #964
feat(aws-sm): added keychain plugin for aws secret manager #964
Conversation
packages/cactus-plugin-keychain-aws-sm/src/main/typescript/index.web.ts
Outdated
Show resolved
Hide resolved
...s/cactus-plugin-keychain-aws-sm/src/main/typescript/plugin-keychain-aws-sm-remote-adapter.ts
Outdated
Show resolved
Hide resolved
packages/cactus-plugin-keychain-aws-sm/src/main/typescript/plugin-keychain-vault-aws-sm.ts
Outdated
Show resolved
Hide resolved
...tus-plugin-keychain-aws-sm/src/main/typescript/webservices/get-keychain-entry-endpoint-v1.ts
Outdated
Show resolved
Hide resolved
...s/cactus-plugin-keychain-aws-sm/src/main/typescript/plugin-keychain-aws-sm-remote-adapter.ts
Outdated
Show resolved
Hide resolved
...s/cactus-plugin-keychain-aws-sm/src/main/typescript/plugin-keychain-aws-sm-remote-adapter.ts
Outdated
Show resolved
Hide resolved
868a1d2
to
b65b7ec
Compare
packages/cactus-plugin-keychain-aws-sm/src/test/typescript/integration/a.ts
Outdated
Show resolved
Hide resolved
...cactus-plugin-keychain-aws-sm/src/test/typescript/integration/plugin-keychain-aws-sm.test.ts
Show resolved
Hide resolved
...cactus-plugin-keychain-aws-sm/src/test/typescript/integration/plugin-keychain-aws-sm.test.ts
Show resolved
Hide resolved
a48d04c
to
4d77763
Compare
1e1e090
to
129c0a5
Compare
packages/cactus-plugin-keychain-aws-sm/src/main/typescript/index.web.ts
Outdated
Show resolved
Hide resolved
...cactus-plugin-keychain-aws-sm/src/test/typescript/integration/plugin-keychain-aws-sm.test.ts
Outdated
Show resolved
Hide resolved
543dc6e
to
ff29cce
Compare
@jagpreetsinghsasan Just double checking, is this ready for review? |
Yes, this is ready for review |
@jagpreetsinghsasan Got it, thanks. To speed things up next time, please use this: https://github.blog/changelog/2019-02-21-re-request-review-on-a-pull-request/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jagpreetsinghsasan I see some things resolved in the comments but the code looks the same as before. Please take a second pass on all the review comments and then hit the re-request review.
...cactus-plugin-keychain-aws-sm/src/test/typescript/integration/plugin-keychain-aws-sm.test.ts
Show resolved
Hide resolved
ff29cce
to
64de577
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jagpreetsinghsasan @elenaizaguirre Same request here regarding the openapi.json cross-references. (see my other comment on the other keychain plugin PRs for details)
Codecov Report
@@ Coverage Diff @@
## main #964 +/- ##
==========================================
- Coverage 73.30% 73.23% -0.08%
==========================================
Files 248 252 +4
Lines 8782 8949 +167
Branches 1025 1044 +19
==========================================
+ Hits 6438 6554 +116
- Misses 1796 1835 +39
- Partials 548 560 +12
Continue to review full report at Codecov.
|
Would you wait my review since I'm asking about this PR on #1017? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jagpreetsinghsasan Please update to all Cactus package version occurrences to 0.6.0
from 0.5.0
(just issued the release) and then run the configure script to also update the lock files as well. Commit all of those changes and then we are ready to merge. Don't forget the squash the commits into a single one.
4b55297
to
59852da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jagpreetsinghsasan Almost forgot, please also
- migrate the tsconfig.json inside your package to match the new boilerplate (see any of the other packages for an example).
- Add an entry to the root tsconfig.json file under the
references
array that points to the new package that is being added in the PR - Do this to all the pending PRs that are adding new packages
59852da
to
144a64e
Compare
Primary Change --- 1. Added new package cactus-plugin-keychain-aws-sm under packages/ 2. Added Localstack under cactus-test-tooling/src/main/typescript for local aws secret manager deployment and testing Refactorings that were also necessary to incorporate 1) and 2) --- 3. Updated public-api.ts under packages/cactus-test-tooling/src/main/typescript for exporting LocalStack class, its interfaces and constants Resolves hyperledger-cacti#912 Signed-off-by: jagpreetsinghsaan <jagpreet.singh.sasan@accenture.com>
047dfc4
to
a0a08eb
Compare
Commit to be reviewed
feat(aws-sm): added keychain playing for aws secret manager
Resolves #912
Signed-off-by: Jagpreet Singh Sasan jagpreet.singh.sasan@accenture.com