add more test for recordRate rate-controller

[tunedev]

Checklist

• A link to the issue/user story that the pull request relates to
• How to recreate the problem without the fix
• Design of the fix
• How to prove that the fix works
• Automated tests that prove the fix keeps on working
• Documentation - any JSDoc, website, or Stackoverflow answers?

Issue/User story

Partially addresses #1606

Steps to Reproduce

Existing issues

• Stack Overflow issues
• GitHub Issues
• Discord history

Design of the fix

Validation of the fix

After this PR: Running the tests in caliper-core the listed %stmts in the code coverage report should tally with the below listed

• caliper-core/lib/worker/recordRate.js: 95.52

Before the PR: Running the tests in caliper-core the listed %stmts in the code coverage report the below listed was what was there before

• caliper-core/lib/worker/recordRate.js: 43.28

What documentation has been provided for this pull request

[davidkel]

Sorry lots of issues with this test I'm afraid

[davidkel]

There appear to be more changes required for this based on previous comments.

[tunedev]

There appear to be more changes required for this based on previous comments.

@davidkel i have tended to them, thanks

[davidkel]

So more issues here I'm afraid, but the sparse population of the records array has shown up bugs but unfortunately you hid by fixing the test, so something to always bare in mind.
On further thought as well for completeness we should also add tests that test records that are not sparse. ie we have continuous values starting at the 0'th record element (eg records[0]=100;records[1]=300;records[2]=500;records[3]=700;) as this is a common scenario as well. So we should have tests for it.

[davidkel]

this test is not correct, as stated in a previous review, the value here should be one more than the value returned by getNumberOfTxs because we can and probably will have an entry for 0 transactions submitted therefore if we have 5 transactions submitted then we would have 0-5 possible records. This will then show there is a bug in the code which needs to be fixed.