fix: throughput faq #1656
Open
fix: throughput faq #1656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prati28 <sankhepratiksha3@gmail.com>
davidkel
reviewed
Nov 16, 2024
| @@ -23,7 +23,8 @@ There is another configuration file, namely `./config/default.yaml`, containing | |||
| ## **IV. Other Questions Related to Caliper** | |||
|
|
|||
| **Q:** How can I calculate the throughput (TPS)? | |||
| **A:** Caliper will record the submitting time and committing time (the time when the Tx is committed on the ledger or when the failure occurred) for each Tx. So the send rate is calculated by `(Succ+Fail) / (last submitting time - first submitting time)`. The throughput is calculated by `Succ/(last committing time - first submitting time)`, here only successful committed Txs will be calculated. | |||
| **A:** Caliper will record the submitting time and committing time (the time when the Tx is committed on the ledger or when the failure occurred) for each Tx. The throughput is calculated by `Succ+Fail/(last committing time - first submitting time)`. This means both successful and failed transactions are included in the throughput calculation. | |||
There was a problem hiding this comment.
We should say here that the throughput and the send rate are calculated using both the successful and failed transactions. Which was in the original paragraph it was just that the final part about throughput was not correct.
davidkel
requested changes
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Issue/User story
#1418
Steps to Reproduce
Existing issues
Design of the fix
Validation of the fix
Automated Tests
What documentation has been provided for this pull request