Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor]: Consider moving metrics related logic to torii #3467

Closed
Erigara opened this issue May 10, 2023 · 0 comments
Closed

[refactor]: Consider moving metrics related logic to torii #3467

Erigara opened this issue May 10, 2023 · 0 comments
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST Refactor Improvement to overall code quality

Comments

@Erigara
Copy link
Contributor

Erigara commented May 10, 2023 •
edited
Loading 

          Good candidate for removal.

Originally posted by @appetrosyan in #3457 (comment)

At the moment we deal with metrics as part of SumeragiHandle, we should consider moving this logic to torii as it's single user of it.
@Erigara Erigara added the Refactor Improvement to overall code quality label May 10, 2023
@Erigara Erigara mentioned this issue May 10, 2023
Merged
5 tasks
@Erigara Erigara changed the title [refactor]: Consider metrics related logic to torii [refactor]: Consider moving metrics related logic to torii May 10, 2023
@Erigara Erigara added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label May 23, 2023
@mversic mversic mentioned this issue Nov 30, 2023
Closed
@mversic mversic closed this as completed Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST Refactor Improvement to overall code quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Erigara @mversic