Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor]: Move metrics into separate service #4075

Closed
Erigara opened this issue Nov 23, 2023 · 1 comment · Fixed by #4379
Closed

[refactor]: Move metrics into separate service #4075

Erigara opened this issue Nov 23, 2023 · 1 comment · Fixed by #4379
Assignees
@Erigara
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST Refactor Improvement to overall code quality

Comments

@Erigara
Copy link
Contributor

Erigara commented Nov 23, 2023 •
edited
Loading 

          it would be nice if we could remove `sumeragi` from `torii`. I see that it is only used with `sumeragi.metrics` and `sumeragi.update_metrics`. Maybe we can make a ticket for this to make metrics a separate service

Originally posted by @mversic in #4061 (comment)

It would be convenient to decouple torii and sumeragii. And after wsv update (#4061) the last thing that requires torii to depend on sumeragi is metrics which should be moved into separate service.
@Erigara Erigara changed the title [refactor]: Move metrics into it's own service [refactor]: Move metrics into separate service Nov 23, 2023
@Erigara Erigara added iroha2-dev The re-implementation of a BFT hyperledger in RUST Refactor Improvement to overall code quality labels Nov 23, 2023
@Erigara Erigara mentioned this issue Nov 23, 2023
Merged
@mversic
Copy link
Contributor

mversic commented Nov 30, 2023

related to #3467

@Erigara Erigara self-assigned this Mar 21, 2024
@Erigara Erigara mentioned this issue Mar 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Erigara Erigara

Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST Refactor Improvement to overall code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[refactor] #4075: Move metrics related functionality into MetricsReporter Erigara/iroha
2 participants
@Erigara @mversic