[fix] #2501: Fixes the order of assets in queries with pagination #2515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
iroha2-dev
pesterev
requested review from
s8sato,
appetrosyan,
mversic,
Arjentix,
SamHSmith,
QuentinI,
outoftardis,
ilchu and
Erigara
as code owners
mversic
reviewed
Jul 21, 2022
mversic
reviewed
Jul 21, 2022
pesterev
force-pushed
the
paginated-ordering
branch
from
4af4d17
to
153b2be
Compare
mversic
reviewed
Jul 21, 2022
pesterev
force-pushed
the
paginated-ordering
branch
from
153b2be
to
6a45f3d
Compare
…th pagination Signed-off-by: Vladimir Pesterev <pesterev@pm.me>
pesterev
force-pushed
the
paginated-ordering
branch
from
6a45f3d
to
820e2cb
Compare
|
Convert this to a draft because the current decision affects memory related optimizations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vladimir Pesterev pesterev@pm.me
Description of the Change
Replaces the lexicographical order of assets with a timestamp-based order in
AssetsMap.For example:
Before:
1 (1658432537),10 (1658432546),2 (1658432538),3 (1658432539),4 (1658432540),5 (1658432541),6 (1658432542),7 (1658432543),8 (1658432544),9 (1658432545).Now:
1 (1658432537),2 (1658432538),3 (1658432539),4 (1658432540),5 (1658432541),6 (1658432542),7 (1658432543),8 (1658432544),9 (1658432545),10 (1658432546).Where
Nis Id andTis an insertion timestamp inN (T)format.Issue
Resolves #2501
Benefits
Order now depends on insertion timestamp.
Possible Drawbacks
The queries that retrieve an asset will execute a bit slower because$O(\log n)$ (current implementation) and $O (\log n + \log n)$ (twice b-tree lookup) (impl in this PR).