Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor]: move instruction len from data_model into core #3685

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

mversic
Copy link
Contributor

@mversic mversic commented Jul 6, 2023

Description

the less functionality we expose in public API the better

Linked issue

Closes #{issue_number}

Benefits

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Jul 6, 2023
@mversic mversic marked this pull request as draft July 6, 2023 12:28
@mversic mversic force-pushed the move_isi_len_to_core branch 2 times, most recently from 3648d51 to eb54766 Compare July 6, 2023 12:35
@mversic mversic marked this pull request as ready for review July 6, 2023 12:36
@coveralls
Copy link

coveralls commented Jul 6, 2023

Pull Request Test Coverage Report for Build 5589398667

  • 74 of 121 (61.16%) changed or added relevant lines in 11 files are covered.
  • 2153 unchanged lines in 46 files lost coverage.
  • Overall coverage decreased (-0.09%) to 59.345%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core/src/smartcontracts/isi/world.rs 0 1 0.0%
core/src/smartcontracts/isi/triggers/mod.rs 0 2 0.0%
core/src/smartcontracts/isi/asset.rs 0 3 0.0%
data_model/src/visit.rs 0 3 0.0%
data_model/derive/src/model.rs 0 4 0.0%
core/src/tx.rs 65 77 84.42%
wasm_codec/derive/src/lib.rs 4 26 15.38%
Files with Coverage Reduction New Missed Lines %
client_cli/src/main.rs 1 0%
client/src/http_default.rs 1 0%
cli/src/main.rs 1 0%
core/src/smartcontracts/isi/asset.rs 1 29.79%
core/src/sumeragi/network_topology.rs 1 96.77%
data_model/src/name.rs 1 94.25%
derive_primitives/src/lib.rs 1 0%
macro/derive/src/lib.rs 1 94.59%
wasm_codec/derive/src/lib.rs 1 86.18%
cli/derive/src/lib.rs 5 93.14%
Totals Coverage Status
Change from base Build 5423219773: -0.09%
Covered Lines: 19851
Relevant Lines: 33450

💛 - Coveralls

wasm_codec/derive/src/lib.rs Outdated Show resolved Hide resolved
client/tests/integration/events/pipeline.rs Show resolved Hide resolved
core/src/smartcontracts/isi/mod.rs Outdated Show resolved Hide resolved
core/src/smartcontracts/isi/mod.rs Outdated Show resolved Hide resolved
core/src/smartcontracts/isi/query.rs Outdated Show resolved Hide resolved
core/src/smartcontracts/mod.rs Outdated Show resolved Hide resolved
core/src/sumeragi/main_loop.rs Outdated Show resolved Hide resolved
data_model/src/isi.rs Show resolved Hide resolved
wasm_codec/derive/src/lib.rs Outdated Show resolved Hide resolved
@mversic mversic force-pushed the move_isi_len_to_core branch 8 times, most recently from 1fe2712 to bd723dd Compare July 7, 2023 10:25
appetrosyan
appetrosyan previously approved these changes Jul 10, 2023
@mversic mversic force-pushed the move_isi_len_to_core branch 2 times, most recently from 7420cc8 to 0b8617a Compare July 11, 2023 06:27
@appetrosyan
Copy link
Contributor

TRYBUILD=overwrite and it should work.

appetrosyan
appetrosyan previously approved these changes Jul 18, 2023
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
core/src/tx.rs Show resolved Hide resolved
core/src/tx.rs Show resolved Hide resolved
@mversic mversic merged commit b24d8c9 into hyperledger-iroha:iroha2-dev Jul 20, 2023
@mversic mversic deleted the move_isi_len_to_core branch July 20, 2023 07:40
mversic added a commit that referenced this pull request Oct 17, 2023
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants