-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor]: move instruction len from data_model into core #3685
Merged
mversic
merged 1 commit into
hyperledger-iroha:iroha2-dev
from
mversic:move_isi_len_to_core
Jul 20, 2023
Merged
[refactor]: move instruction len from data_model into core #3685
mversic
merged 1 commit into
hyperledger-iroha:iroha2-dev
from
mversic:move_isi_len_to_core
Jul 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mversic
requested review from
s8sato,
appetrosyan,
Arjentix,
SamHSmith,
QuentinI,
outoftardis,
ilchu,
pesterev,
Erigara,
0x009922 and
DCNick3
as code owners
July 6, 2023 12:25
github-actions
bot
added
the
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
label
Jul 6, 2023
mversic
force-pushed
the
move_isi_len_to_core
branch
2 times, most recently
from
July 6, 2023 12:35
3648d51
to
eb54766
Compare
Pull Request Test Coverage Report for Build 5589398667
💛 - Coveralls |
mversic
commented
Jul 6, 2023
appetrosyan
reviewed
Jul 7, 2023
mversic
force-pushed
the
move_isi_len_to_core
branch
8 times, most recently
from
July 7, 2023 10:25
1fe2712
to
bd723dd
Compare
appetrosyan
previously approved these changes
Jul 10, 2023
mversic
force-pushed
the
move_isi_len_to_core
branch
2 times, most recently
from
July 11, 2023 06:27
7420cc8
to
0b8617a
Compare
mversic
force-pushed
the
move_isi_len_to_core
branch
from
July 12, 2023 07:38
0b8617a
to
0847a48
Compare
appetrosyan
force-pushed
the
move_isi_len_to_core
branch
from
July 12, 2023 08:10
0847a48
to
c0987cf
Compare
|
mversic
force-pushed
the
move_isi_len_to_core
branch
8 times, most recently
from
July 14, 2023 08:23
41da738
to
fae6107
Compare
appetrosyan
force-pushed
the
move_isi_len_to_core
branch
from
July 17, 2023 08:06
fae6107
to
25c3bb8
Compare
appetrosyan
force-pushed
the
move_isi_len_to_core
branch
from
July 18, 2023 07:48
25c3bb8
to
fc66dab
Compare
appetrosyan
previously approved these changes
Jul 18, 2023
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
mversic
force-pushed
the
move_isi_len_to_core
branch
from
July 18, 2023 15:27
fc66dab
to
d19dd36
Compare
appetrosyan
approved these changes
Jul 18, 2023
0x009922
approved these changes
Jul 20, 2023
mversic
added a commit
that referenced
this pull request
Oct 17, 2023
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
the less functionality we expose in public API the better
Linked issue
Closes #{issue_number}
Benefits
Checklist
CONTRIBUTING.md