-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor] #3289: Use workspace inheritance #3708
Merged
appetrosyan
merged 1 commit into
hyperledger-iroha:iroha2-dev
from
DCNick3:workspace-deps
Jul 17, 2023
Merged
[refactor] #3289: Use workspace inheritance #3708
appetrosyan
merged 1 commit into
hyperledger-iroha:iroha2-dev
from
DCNick3:workspace-deps
Jul 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DCNick3
requested review from
s8sato,
appetrosyan,
mversic,
Arjentix,
SamHSmith,
QuentinI,
outoftardis,
ilchu,
pesterev,
Erigara and
0x009922
as code owners
July 13, 2023 14:18
github-actions
bot
added
the
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
label
Jul 13, 2023
Pull Request Test Coverage Report for Build 5580834861
💛 - Coveralls |
pesterev
reviewed
Jul 13, 2023
8 tasks
0x009922
previously approved these changes
Jul 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aahh, so pleasant set of changes.
As for clap
's v3 vs v4: it was quite easy to migrate in Kagami. However, it is better to do in a separate PR.
appetrosyan
reviewed
Jul 17, 2023
Signed-off-by: Nikita Strygin <DCNick3@users.noreply.github.com>
appetrosyan
force-pushed
the
workspace-deps
branch
from
July 17, 2023 21:34
e35cc54
to
287df65
Compare
appetrosyan
approved these changes
Jul 17, 2023
DCNick3
added a commit
to DCNick3/iroha
that referenced
this pull request
Jul 18, 2023
…-iroha#3708 to make UI tests pass Signed-off-by: Nikita Strygin <DCNick3@users.noreply.github.com>
appetrosyan
pushed a commit
that referenced
this pull request
Jul 18, 2023
Signed-off-by: Nikita Strygin <DCNick3@users.noreply.github.com>
mversic
pushed a commit
that referenced
this pull request
Oct 17, 2023
Signed-off-by: Nikita Strygin <DCNick3@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR extracts all common dependencies (2 usages or more) into a workspace level, so that it is easier to update them in lockstep.
Also, all iroha crates besides except inner
_derive
crates are also specified at workspace level.Issues
There are two places where I couldn't unify the dependencies:
tokio-tungstenite
of versions 0.16 and 0.17 is usedhttps://github.com/hyperledger/iroha/blob/39504a5a8029080e0a7fe93b0f06a74710dba347/client/Cargo.toml#L44-L43
clap
v3 and v4 is used:https://github.com/hyperledger/iroha/blob/39504a5a8029080e0a7fe93b0f06a74710dba347/client_cli/Cargo.toml#L31-L30
I haven't tried too hard, but it seems that it would require some code changes to update these places.
Linked issue
Closes #3289