Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] #3451: Fix docker build on M1 #3747

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

ilchu
Copy link
Contributor

@ilchu ilchu commented Jul 26, 2023

Description

The docker build on M1 was failing because of lacking platform tag at first, and then because of some missing links to wasm-opt's musl binaries.

Linked issue

Closes #3451.

Benefits

Finally local docker launching as expected on M1 machines, abysmal build times notwithstanding.

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@ilchu ilchu self-assigned this Jul 26, 2023
@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Jul 26, 2023
@coveralls
Copy link

coveralls commented Jul 26, 2023

Pull Request Test Coverage Report for Build 5695117197

  • 13 of 15 (86.67%) changed or added relevant lines in 2 files are covered.
  • 4183 unchanged lines in 82 files lost coverage.
  • Overall coverage decreased (-1.5%) to 57.935%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tools/kagami/src/genesis.rs 0 1 0.0%
tools/kagami/src/swarm.rs 13 14 92.86%
Files with Coverage Reduction New Missed Lines %
client_cli/src/main.rs 1 0%
cli/src/main.rs 1 0%
cli/src/torii/pagination.rs 1 98.9%
config/base/src/runtime_upgrades.rs 1 51.72%
config/src/torii.rs 1 96.67%
core/src/smartcontracts/isi/block.rs 1 87.5%
core/src/sumeragi/network_topology.rs 1 96.76%
crypto/src/merkle.rs 1 96.23%
data_model/src/account.rs 1 52.21%
data_model/src/domain.rs 1 47.37%
Totals Coverage Status
Change from base Build 5423219773: -1.5%
Covered Lines: 19790
Relevant Lines: 34159

💛 - Coveralls

Copy link
Contributor

@0x009922 0x009922 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I could not approve. Unfortunately, I could not check how it works on my machine. There are Docker errors, which I don't want to debug, because too much effort for too less output.

@appetrosyan
Copy link
Contributor

Works on my M2 machine.

@ilchu
Copy link
Contributor Author

ilchu commented Jul 28, 2023

LGTM, but I could not approve. Unfortunately, I could not check how it works on my machine. There are Docker errors, which I don't want to debug, because too much effort for too less output.

Which errors specifically? It would need to be verified by QA anyways, but I want to make it as robust as possible still. And I do agree debugging it is really frustrating.

Copy link
Contributor

@Arjentix Arjentix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Takes forever to build on my M1. Complains a lot about jemalloc. So same as before.
I wasn't able to wait until it builds, but overall looks fine.

Signed-off-by: Ilia Churin <churin.ilya@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants