-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] #3964: application/x-parity-scale
response for /status
…
#3983
Merged
0x009922
merged 10 commits into
hyperledger-iroha:iroha2-dev
from
0x009922:3964-status-scale
Oct 31, 2023
Merged
[feature] #3964: application/x-parity-scale
response for /status
…
#3983
0x009922
merged 10 commits into
hyperledger-iroha:iroha2-dev
from
0x009922:3964-status-scale
Oct 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
label
Oct 12, 2023
Pull Request Test Coverage Report for Build 6703625156
💛 - Coveralls |
0x009922
force-pushed
the
3964-status-scale
branch
from
October 13, 2023 01:42
752d354
to
549d0a6
Compare
0x009922
requested review from
s8sato,
appetrosyan,
mversic,
Arjentix,
SamHSmith,
QuentinI,
outoftardis,
ilchu,
pesterev,
Erigara and
DCNick3
as code owners
October 13, 2023 02:02
0x009922
force-pushed
the
3964-status-scale
branch
from
October 16, 2023 01:17
549d0a6
to
4b56493
Compare
DCNick3
reviewed
Oct 16, 2023
6r1d
force-pushed
the
iroha2-dev
branch
2 times, most recently
from
October 17, 2023 11:50
66fec94
to
bf90a7d
Compare
0x009922
force-pushed
the
3964-status-scale
branch
2 times, most recently
from
October 20, 2023 02:26
228e94f
to
e941a3c
Compare
DCNick3
previously approved these changes
Oct 20, 2023
0x009922
force-pushed
the
3964-status-scale
branch
from
October 23, 2023 03:09
e941a3c
to
12d6c28
Compare
0x009922
added
Enhancement
New feature or request
api-changes
Changes in the API for client libraries
labels
Oct 23, 2023
0x009922
force-pushed
the
3964-status-scale
branch
from
October 23, 2023 09:58
12d6c28
to
2ff6a75
Compare
DCNick3
previously approved these changes
Oct 23, 2023
pesterev
suggested changes
Oct 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT, but one thing needs to be corrected.
pesterev
approved these changes
Oct 31, 2023
0x009922
force-pushed
the
3964-status-scale
branch
from
October 31, 2023 04:43
9b32ed6
to
5afe97a
Compare
DCNick3
approved these changes
Oct 31, 2023
…se for `/status` endpoint Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
0x009922
force-pushed
the
3964-status-scale
branch
from
October 31, 2023 08:00
5afe97a
to
fb3eaa5
Compare
6r1d
pushed a commit
that referenced
this pull request
Oct 31, 2023
#3983) Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com> Signed-off-by: 6r1d <vic.6r1d@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api-changes
Changes in the API for client libraries
Enhancement
New feature or request
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New features:
GET /status
acceptsapplication/x-parity-scale
content type and responds accordinglyGET /status/<field>
now accepts nested paths, e.g./status/uptime/secs
Breaking changes:
GET /status/<field>
used to be forgiving for path-not-found and serialization errors. Now it returns 404 and 500 errors accordingly.Content-Type: application/x-parity-scale
Linked issue
Closes #3964
Benefits
JavaScript SDK can use
/status
endpoint without hacks around JSON parsing.Checklist
GET /status
reference iroha-2-docs#422/status
endpointContent-Type: application/x-parity-scale
for other endpoints which use SCALE for response encoding