[feature] #3900: fetch_size query parameter

[Arjentix]

Description

Linked issue

• fetch_size is no more a configuration parameter but a query parameter. Clients have to send it as a query parameter.
• Added integration test

• Closes Server-side cursor fetch_size per query #3900

Benefits

• Clients can configure how big batches they want

Checklist

• I've read CONTRIBUTING.md
• I've used the standard signed-off commit format (or will squash just before merging)
• All applicable CI checks pass (or I promised to make them pass later)
• (optional) I've written unit tests integration test for the code changes
• I replied to all comments after code review, marking all implemented changes with thumbs up

[coveralls]

Pull Request Test Coverage Report for Build 6811282567

• 19 of 102 (18.63%) changed or added relevant lines in 11 files are covered.
• 6915 unchanged lines in 128 files lost coverage.
• Overall coverage decreased (-4.0%) to 55.39%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
cli/src/torii/mod.rs	0	1	0.0%
client/src/query_builder.rs	0	6	0.0%
core/src/smartcontracts/wasm.rs	4	10	40.0%
core/src/query/cursor.rs	0	7	0.0%
cli/src/torii/routing.rs	0	10	0.0%
client/src/client.rs	1	11	9.09%
core/src/query/store.rs	1	12	8.33%
data_model/src/query/mod.rs	5	21	23.81%
smart_contract/src/lib.rs	0	16	0.0%

Files with Coverage Reduction	New Missed Lines	%
config/base/derive/src/view.rs	1	99.37%
config/src/block_sync.rs	1	95.0%
config/src/network.rs	1	93.75%
config/src/torii.rs	1	95.45%
config/src/wasm.rs	1	87.5%
core/src/smartcontracts/isi/block.rs	1	87.5%
config/src/kura.rs	2	79.41%
config/src/lib.rs	2	0.0%
ffi/src/option.rs	2	71.43%
config/src/genesis.rs	3	72.92%

Totals
Change from base Build 5423219773:	-4.0%
Covered Lines:	22142
Relevant Lines:	39975

---

💛 - Coveralls

[Erigara]

Imo we should limit maximum size of fetch_size.

[Arjentix]

Imo we should limit maximum size of fetch_size.

But how? Using another config parameter?

[Erigara]

But how? Using another config parameter?

Or hardcode, however we can leave this as is for now.

misclick...

[0x009922]

Merging only after a PR to update Torii Endpoints page is created.

upd: sorry for ultimate tone, just tired from having outdated docs.

[Arjentix]

Imo we should limit maximum size of fetch_size.

But how? Using another config parameter?

Or hardcode, however we can leave this as is for now.

@mversic , what do you think about that?

[Arjentix]

Merging only after a PR to update Torii Endpoints page is created.

@0x009922 , is it iroha2-docs repo?

[mversic]

Imo we should limit maximum size of fetch_size.

But how? Using another config parameter?

Or hardcode, however we can leave this as is for now.

@mversic , what do you think about that?

I think it's ok to just hardcode

[0x009922]

Merging only after a PR to update Torii Endpoints page is created.

@0x009922 , is it iroha2-docs repo?

@Arjentix, yes. At the bottom of the page you might find "Edit this page on GitHub" link for convenience.

[Arjentix]

@0x009922 , created hyperledger-iroha/iroha-2-docs#425

[mversic]

Imo we should limit maximum size of fetch_size.

But how? Using another config parameter?

Or hardcode, however we can leave this as is for now.

@mversic , what do you think about that?

I think it's ok to just hardcode

I would like to backport this into RC20. But in the backport we have to leave in the config intact since removing it would break backwards compatibility

[Arjentix]

I would like to backport this into RC20. But in the backport we have to leave in the config intact since removing it would break backwards compatibility

Ok, will do in separate PR

[Arjentix]

@mversic , I tried and turns out this PR uses a lot from #3958 which is not merged into stable.

Also this seems to be a feature, while AFAIK only bug-fix backports make sence

[mversic]

Also this seems to be a feature, while AFAIK only bug-fix backports make sence

ideally, only bugfixes would be backported. However, this feature was requested by Orillion.
Nvm, if not possible

Docs written