Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] #4116: Add test for plain == scale encoded verification for status request #4284

Merged
merged 5 commits into from
Mar 13, 2024
Merged

Conversation

VAmuzing
Copy link
Contributor

@VAmuzing VAmuzing commented Feb 16, 2024

Description

While checking #4116 I found helpful to verify that scale encoded response was equal to plain with this test.
It also might come in handy when we eventually move from warp to something like axum.

Linked issue

Relates to #4116

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@VAmuzing VAmuzing self-assigned this Feb 16, 2024
@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Feb 16, 2024
@VAmuzing VAmuzing added the Tests label Feb 16, 2024
@coveralls
Copy link

coveralls commented Feb 16, 2024

Pull Request Test Coverage Report for Build 8265657921

Details

  • 1 of 25 (4.0%) changed or added relevant lines in 3 files are covered.
  • 4150 unchanged lines in 77 files lost coverage.
  • Overall coverage decreased (-0.2%) to 56.609%

Changes Missing Coverage Covered Lines Changed/Added Lines %
client/src/lib.rs 0 5 0.0%
telemetry/src/metrics.rs 1 9 11.11%
client/src/client.rs 0 11 0.0%
Files with Coverage Reduction New Missed Lines %
primitives/src/conststr.rs 1 91.14%
ffi/derive/src/convert.rs 1 84.45%
primitives/src/lib.rs 1 0.0%
core/src/sumeragi/network_topology.rs 1 98.78%
crypto/src/signature/bls/mod.rs 2 0.0%
data_model/derive/src/has_origin.rs 3 95.16%
config/src/kura.rs 3 80.0%
primitives/src/addr.rs 3 63.82%
schema/derive/src/lib.rs 5 83.25%
config/src/logger.rs 5 72.73%
Totals Coverage Status
Change from base Build 7884695009: -0.2%
Covered Lines: 22134
Relevant Lines: 39100

💛 - Coveralls

@VAmuzing VAmuzing changed the title [feature] #4116: Add test for plain == scale verification for status request [feature] #4116: Add test for plain == scale encoded verification for status request Feb 16, 2024
@Erigara Erigara self-assigned this Feb 16, 2024
Copy link
Contributor

@Erigara Erigara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please pick free port

Erigara
Erigara previously approved these changes Feb 19, 2024
Copy link
Contributor

@0x009922 0x009922 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, why not use only SCALE in iroha_client's get_status implementation? It's win-win, isn't it?

client/src/client.rs Outdated Show resolved Hide resolved
@VAmuzing
Copy link
Contributor Author

Actually, why not use only SCALE in iroha_client's get_status implementation? It's win-win, isn't it?

It's unreadable if we poll it from outside, like from curl. If this feature is unused then we indeed can switch to SCALE only.

@0x009922
Copy link
Contributor

If this feature is unused then we indeed can switch to SCALE only.

I think it is unused.

0x009922
0x009922 previously approved these changes Mar 5, 2024
client/src/lib.rs Show resolved Hide resolved
Erigara
Erigara previously approved these changes Mar 11, 2024
@VAmuzing VAmuzing dismissed stale reviews from 0x009922 and Erigara via 9140215 March 13, 2024 02:47
Signed-off-by: VAmuzing <amuzik95@gmail.com>
Signed-off-by: VAmuzing <amuzik95@gmail.com>
Signed-off-by: VAmuzing <amuzik95@gmail.com>
Signed-off-by: VAmuzing <amuzik95@gmail.com>
Signed-off-by: VAmuzing <amuzik95@gmail.com>
@VAmuzing VAmuzing merged commit be0e67f into hyperledger-iroha:iroha2-dev Mar 13, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants