Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] #3354: Different fuel limit for Executor #4302

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

Arjentix
Copy link
Contributor

Linked issue

Benefits

Now users can specify different limits for Executor and for other WASM

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@Arjentix Arjentix added Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST labels Feb 19, 2024
@Arjentix Arjentix self-assigned this Feb 19, 2024
@coveralls
Copy link

coveralls commented Feb 19, 2024

Pull Request Test Coverage Report for Build 7978550681

Details

  • -6 of 19 (68.42%) changed or added relevant lines in 6 files are covered.
  • 2948 unchanged lines in 53 files lost coverage.
  • Overall coverage decreased (-0.3%) to 56.506%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tools/kagami/src/genesis.rs 0 2 0.0%
core/src/executor.rs 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
core/src/sumeragi/network_topology.rs 1 98.78%
tools/kagami/src/crypto.rs 1 12.12%
data_model/src/metadata.rs 2 78.87%
primitives/src/unique_vec.rs 2 91.24%
config/src/kura.rs 3 80.0%
config/src/logger.rs 5 72.73%
logger/src/lib.rs 5 94.12%
tools/kagami/src/main.rs 5 0.0%
telemetry/src/dev.rs 7 0.0%
core/src/smartcontracts/isi/mod.rs 8 76.49%
Totals Coverage Status
Change from base Build 7884695009: -0.3%
Covered Lines: 22412
Relevant Lines: 39663

💛 - Coveralls

@VAmuzing VAmuzing self-assigned this Feb 19, 2024
@0x009922 0x009922 added the config-changes Changes in configuration and start up of the Iroha label Feb 20, 2024
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
@Arjentix Arjentix merged commit 64e9e31 into hyperledger-iroha:iroha2-dev Feb 20, 2024
12 checks passed
@Arjentix Arjentix deleted the executor_fuel branch February 20, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config-changes Changes in configuration and start up of the Iroha Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants