fix: prevent redundant blocksync block messages #4909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamHSmith
requested review from
s8sato,
mversic,
outoftardis,
Erigara,
0x009922,
DCNick3 and
dima74
as code owners
Erigara
reviewed
Jul 29, 2024
mversic
requested changes
Jul 30, 2024
|
this should be backported to rc22 |
SamHSmith
force-pushed
the
smart_block_sync
branch
3 times, most recently
from
91eb3a1
to
fcafd58
Compare
|
you have a failing test in torii api |
SamHSmith
force-pushed
the
smart_block_sync
branch
3 times, most recently
from
068c470
to
8f64585
Compare
It has now been fixed. |
Erigara
previously approved these changes
Aug 7, 2024
mversic
previously approved these changes
Aug 8, 2024
mversic
force-pushed
the
smart_block_sync
branch
from
8f64585
to
3ce6a03
Compare
mversic
reviewed
Aug 8, 2024
mversic
reviewed
Aug 8, 2024
mversic
reviewed
Aug 8, 2024
SamHSmith
force-pushed
the
smart_block_sync
branch
2 times, most recently
from
fa756e9
to
9b46f17
Compare
Signed-off-by: Sam H. Smith <sam.henning.smith@protonmail.com>
SamHSmith
force-pushed
the
smart_block_sync
branch
from
9b46f17
to
dd22032
Compare
Erigara
approved these changes
Aug 8, 2024
mversic
approved these changes
Aug 8, 2024
mversic
pushed a commit
that referenced
this pull request
Aug 30, 2024
Signed-off-by: Sam H. Smith <sam.henning.smith@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was a problem during TPS testing where block sync could not occur quickly because it would re-request the
same blocks from each peer. Here is a solution that should be robust against that scenario but doesn't introduce
any new issues.
Linked issue
Closes #{issue_number}
Benefits
Checklist
CONTRIBUTING.md