Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Leader as transaction ordering service #4967

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

SamHSmith
Copy link
Contributor

Description

#4914

Linked issue

Closes #{issue_number}

Benefits

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@mversic
Copy link
Contributor

mversic commented Aug 13, 2024

you should follow the style of the code and add a new state to the block state machine. Let's consider this in more detail:

  1. remove categorize_transactions function
  2. make BlockBuilder::new -> BlockBuilder::chain -> BlockBuilder::sign produce SignedBlock(not ValidBlock)

@SamHSmith SamHSmith force-pushed the tx_order branch 2 times, most recently from c329d6c to 81e0bf2 Compare September 9, 2024 21:33
@SamHSmith SamHSmith marked this pull request as ready for review September 9, 2024 21:35
@SamHSmith SamHSmith force-pushed the tx_order branch 2 times, most recently from 619b997 to c89a385 Compare September 11, 2024 19:06
Copy link
Contributor

@Erigara Erigara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there is any performance boost measurements?

crates/iroha_core/src/sumeragi/main_loop.rs Outdated Show resolved Hide resolved
crates/iroha_core/src/sumeragi/main_loop.rs Outdated Show resolved Hide resolved
crates/iroha_core/src/sumeragi/main_loop.rs Show resolved Hide resolved
crates/iroha_data_model/src/block.rs Outdated Show resolved Hide resolved
crates/iroha_core/src/block.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@mversic mversic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see that CommittedTransaction::error is being updated anywhere

@SamHSmith SamHSmith force-pushed the tx_order branch 6 times, most recently from 73139b6 to da1eff9 Compare October 7, 2024 07:45
@mversic mversic requested a review from Erigara October 7, 2024 08:54
Signed-off-by: Sam H. Smith <sam.henning.smith@protonmail.com>
@mversic mversic merged commit 242d857 into hyperledger-iroha:main Oct 8, 2024
11 of 12 checks passed
@alexstroke1 alexstroke1 self-assigned this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants