-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: reorganize crates #4970
feat!: reorganize crates #4970
Conversation
59851dd
to
0c265fe
Compare
0c265fe
to
f51296d
Compare
I suggest to name |
|
0738615
to
3e6a378
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would advocate to go even further with flattening: to lift crates such as iroha_config/base
, iroha_schema/derive
etc to the top level as well and keep the crates structure completely flat.
Also what about nesting all crates specifically into /crates
directory or something?
I also don't see a good reason why pytests (for client and torii) are located next to the respective crates. I mean, yes, the crates are indeed respective, but related pytests have nothing to do with the crates - they are integrational tests interacting with bare-metal running Iroha peer. Thus, I'd advocate to put them somewhere on the top level as well and avoid their unnecessarily deep nesting.
Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
…asm_codec_derive` Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
772b0ef
to
ab4c1de
Compare
Description
iroha_client_cli
toiroha_cli
iroha_wasm_builder
andiroha_wasm_builder_cli
kagami
toiroha_kagami
(crate only, not binary)parity_scale_cli
crate toiroha_codec
/crates
/pytests
Linked issue
Closes #4915, part of #2933.
Benefits
iroha_cli
a bit more convenient to installiroha_wasm_builder
more convenient to installkagami
no longer conflicts with an existing crateiroha_trigger
andiroha_executor
no longer hidden insideiroha_smart_contract
Checklist
CONTRIBUTING.md