fix: Serialize WASM code for snapshots #5009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dima74
requested review from
s8sato,
mversic,
SamHSmith,
outoftardis,
Erigara,
0x009922 and
DCNick3
as code owners
github-actions
bot
added
the
config-changes
mversic
previously approved these changes
Aug 26, 2024
Signed-off-by: Dmitry Murzin <diralik@yandex.ru>
dima74
force-pushed
the
diralik/fix-snapshot-wasm
branch
from
70a9ded
to
0323138
Compare
DCNick3
reviewed
Aug 26, 2024
Signed-off-by: Dmitry Murzin <diralik@yandex.ru>
mversic
approved these changes
Aug 26, 2024
DCNick3
approved these changes
Aug 26, 2024
mversic
pushed a commit
that referenced
this pull request
Aug 30, 2024
Signed-off-by: Dmitry Murzin <diralik@yandex.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
See #4955 (comment) for details
Solution
Use WASM code for snapshot instead of
wasmtime::ModuleReview notes (optional)
Checklist
CONTRIBUTING.md.