fix: address check-cfg warnings + chores
#5135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x009922
added
the
Chore
0x009922
requested review from
s8sato,
mversic,
SamHSmith,
outoftardis,
Erigara,
DCNick3 and
dima74
as code owners
0x009922
force-pushed
the
4993-fix-cfg-warnings
branch
from
b009890
to
76b4afd
Compare
0x009922
commented
Oct 8, 2024
DCNick3
previously approved these changes
Oct 8, 2024
mversic
reviewed
Oct 8, 2024
mversic
reviewed
Oct 8, 2024
mversic
reviewed
Oct 8, 2024
0x009922
force-pushed
the
4993-fix-cfg-warnings
branch
from
a7abadb
to
a5ecf8c
Compare
DCNick3
approved these changes
Oct 9, 2024
mversic
approved these changes
Oct 10, 2024
Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com>
Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com>
Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com>
Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com>
mversic
force-pushed
the
4993-fix-cfg-warnings
branch
from
70c546a
to
4fee2ef
Compare
|
@mversic can we move this task to done? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Close #4993 (see context there)
I found yet another time that metrics & telemetry is broken in Iroha. This PR doesn't fix it, but disables more parts of it to remove noisy warnings. Main issue is #5134
Migration Guide (optional)
Review notes (optional)
Checklist
CONTRIBUTING.md.