Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: address check-cfg warnings + chores #5135

Merged
merged 4 commits into from
Oct 10, 2024

Conversation

0x009922
Copy link
Contributor

@0x009922 0x009922 commented Oct 8, 2024

Context

Close #4993 (see context there)

I found yet another time that metrics & telemetry is broken in Iroha. This PR doesn't fix it, but disables more parts of it to remove noisy warnings. Main issue is #5134

Migration Guide (optional)


Review notes (optional)

Checklist

  • I've read CONTRIBUTING.md.
  • (optional) I've written unit tests for the code changes.
  • All review comments have been resolved.
  • All CI checks pass.

@0x009922 0x009922 added the Chore This is a small task that can be done at any point in time and is easier than others label Oct 8, 2024
@0x009922 0x009922 self-assigned this Oct 8, 2024
DCNick3
DCNick3 previously approved these changes Oct 8, 2024
@0x009922 0x009922 enabled auto-merge (squash) October 8, 2024 07:51
Cargo.toml Outdated Show resolved Hide resolved
@0x009922 0x009922 requested a review from mversic October 9, 2024 07:05
Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com>
Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com>
Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com>
Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com>
@0x009922 0x009922 merged commit 9a0226f into hyperledger-iroha:main Oct 10, 2024
11 of 14 checks passed
@0x009922 0x009922 deleted the 4993-fix-cfg-warnings branch October 10, 2024 07:41
@dmitrivenger
Copy link

@mversic can we move this task to done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chore This is a small task that can be done at any point in time and is easier than others
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected feature flags
4 participants