Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: increase type safety of block lifecycle #5140

Merged
merged 1 commit into from
Oct 11, 2024
Merged

refactor: increase type safety of block lifecycle #5140

merged 1 commit into from
Oct 11, 2024

Conversation

mversic
Copy link
Contributor

@mversic mversic commented Oct 9, 2024

Context

  • increased type safety around block creation
  • introduced new Created event for blocks
  • relaxed conditions for signature validation

Solution

  • Describe the approach taken to achieve the objective / resolve the issue.

Migration Guide (optional)

  • If this PR contains a breaking change relative to the main branch, provide an instruction on how affected parties might need to adapt to the change.

Review notes (optional)

  • For complex PRs, try to provide some information on how to approach the review more effectively.
  • For example, is there a natural order in which the affected files should be reviewed?

Checklist

  • I've read CONTRIBUTING.md.
  • (optional) I've written unit tests for the code changes.
  • All review comments have been resolved.
  • All CI checks pass.

@github-actions github-actions bot added the api-changes Changes in the API for client libraries label Oct 9, 2024
@mversic mversic mentioned this pull request Oct 10, 2024
Merged
s8sato
s8sato reviewed Oct 10, 2024
View reviewed changes
crates/iroha_data_model/src/block.rs Show resolved Hide resolved
crates/iroha_core/src/block.rs Show resolved Hide resolved
crates/iroha_data_model/src/block.rs Outdated Show resolved Hide resolved
crates/iroha_core/src/sumeragi/main_loop.rs Show resolved Hide resolved
@mversic mversic force-pushed the new_block_lifecycle branch 2 times, most recently from f526f39 to f11c187 Compare October 10, 2024 06:55
@mversic mversic mentioned this pull request Oct 10, 2024
Open
@mversic
refactor: increase type safety of block lifecycle
3082cb3 
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
@mversic mversic enabled auto-merge (squash) October 10, 2024 13:14
@mversic mversic merged commit c1b8563 into hyperledger-iroha:main Oct 11, 2024
18 of 19 checks passed
@mversic mversic deleted the new_block_lifecycle branch October 11, 2024 08:16
@0x009922
Copy link
Contributor

This PR caused regression in tests in #5124, namely in extra_functional::genesis::*. irohad panics here:

https://github.com/hyperledger/iroha/blob/c1b8563086db77155d0c90e30bac14a1bc2a54a5/crates/iroha_core/src/sumeragi/main_loop.rs#L396

@0x009922 0x009922 mentioned this pull request Oct 16, 2024
Merged
8 tasks
0x009922 added a commit to 0x009922/iroha that referenced this pull request Oct 17, 2024
@0x009922 @mversic
revert: redundant assert from hyperledger-iroha#5140
779408e 
Co-authored-by: Marin Veršić <marin.versic101@gmail.com>
Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com>
0x009922 added a commit to 0x009922/iroha that referenced this pull request Oct 17, 2024
@0x009922 @mversic
revert: redundant assert from hyperledger-iroha#5140
6e69436 
Co-authored-by: Marin Veršić <marin.versic101@gmail.com>
Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com>
0x009922 added a commit to 0x009922/iroha that referenced this pull request Oct 18, 2024
@0x009922 @mversic
revert: redundant assert from hyperledger-iroha#5140
de61fd5 
Co-authored-by: Marin Veršić <marin.versic101@gmail.com>
Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com>
mversic pushed a commit that referenced this pull request Oct 18, 2024
@0x009922
refactor!: black-box integration tests (#5124)
bc79734 
fix: lints, correct upload of `executor.wasm`
fix: make `iroha_core` compile without `telemetry` feature
ci: copy executor from script; debug; single test command
ci: remove debug, enable full tests
chore: remove rebase artifact
ci: upload test network artifacts
ci: add `ci` nextest profile
fix: chores after rebase; print STDERR; handle early peer termination
ci: use `NEXTEST_PROFILE` env var
test: simplify parameter setting test
chore: fix cargo suggestion, add `--path`
refactor: replace `consensus_estimation` with `pipeline_time`
test: adjust nextest profiles
chore: update comment about kura test
revert: redundant assert from #5140
ci: set retention days to 3 for test network runs
ci: upload artifacts only on failure
chore: use `expect`
ci: refine artifacts upload policy

---------

Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dima74 dima74 dima74 approved these changes

@s8sato s8sato s8sato approved these changes

@SamHSmith SamHSmith Awaiting requested review from SamHSmith SamHSmith is a code owner

@outoftardis outoftardis Awaiting requested review from outoftardis outoftardis is a code owner

@Erigara Erigara Awaiting requested review from Erigara

@0x009922 0x009922 Awaiting requested review from 0x009922 0x009922 is a code owner

@DCNick3 DCNick3 Awaiting requested review from DCNick3

Assignees

@dima74 dima74

@mversic mversic

@s8sato s8sato

Labels
api-changes Changes in the API for client libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mversic @0x009922 @dima74 @s8sato