Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: remove max prefix from blocks_in_memory #5145

Merged
merged 1 commit into from
Oct 14, 2024
Merged

refactor!: remove max prefix from blocks_in_memory #5145

merged 1 commit into from
Oct 14, 2024

Conversation

mversic
Copy link
Contributor

@mversic mversic commented Oct 10, 2024

closes #5108

@mversic mversic self-assigned this Oct 10, 2024
@mversic mversic enabled auto-merge (squash) October 10, 2024 11:27
0x009922
0x009922 requested changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@0x009922 0x009922 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update peer.template.toml too.

@0x009922 0x009922 added the config-changes Changes in configuration and start up of the Iroha label Oct 11, 2024
0x009922
0x009922 requested changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@0x009922 0x009922 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And it seems this parameter is not covered in *.toml in fixures. Could you add it there and ensure it passes?

@mversic
refactor!: remove max prefix from blocks_in_memory
79f7d05 
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
@mversic mversic force-pushed the rename_kura_max_blocks_in_memory branch from b33df4d to 79f7d05 Compare October 12, 2024 06:19
@mversic mversic requested a review from 0x009922 October 12, 2024 06:19
@github-actions GitHub Actions
Copy link

@BAStos525

@hyperledger-iroha hyperledger-iroha deleted a comment from 0x009922 Oct 12, 2024
@mversic
Copy link
Contributor Author

mversic commented Oct 12, 2024

And it seems this parameter is not covered in *.toml in fixures. Could you add it there and ensure it passes?

done

@mversic mversic merged commit a5ea8e5 into hyperledger-iroha:main Oct 14, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Erigara Erigara Erigara approved these changes

@0x009922 0x009922 0x009922 approved these changes

@s8sato s8sato Awaiting requested review from s8sato s8sato is a code owner

@SamHSmith SamHSmith Awaiting requested review from SamHSmith SamHSmith is a code owner

@outoftardis outoftardis Awaiting requested review from outoftardis outoftardis is a code owner

@DCNick3 DCNick3 Awaiting requested review from DCNick3

@dima74 dima74 Awaiting requested review from dima74 dima74 is a code owner

Assignees

@0x009922 0x009922

@mversic mversic

@s8sato s8sato

Labels
config-changes Changes in configuration and start up of the Iroha
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename max_blocks_in_memory to blocks_in_memory
4 participants
@mversic @Erigara @0x009922 @s8sato