Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Add more possible sonar coverage params #5194

Merged
merged 1 commit into from
Oct 25, 2024
Merged

ci: Add more possible sonar coverage params #5194

merged 1 commit into from
Oct 25, 2024

Conversation

BAStos525
Copy link
Contributor

@BAStos525 BAStos525 commented Oct 24, 2024 •
edited
Loading

Context

Sonar coverage doesn't work with llvm-cov.

Solution

Add more possible coverage params.

Checklist

  • I've read CONTRIBUTING.md.
  • (optional) I've written unit tests for the code changes.
  • All review comments have been resolved.
  • All CI checks pass.

@BAStos525 BAStos525 self-assigned this Oct 24, 2024
@BAStos525
ci: Add more sonar coverage params
b5f0146 
Signed-off-by: BAStos525 <jungle.vas@yandex.ru>
@BAStos525 BAStos525 changed the title ci: add gcov.reportsPath sonar parameter ci: Add more possible sonar coverage params Oct 25, 2024
@BAStos525 BAStos525 marked this pull request as ready for review October 25, 2024 09:02
@nxsaken nxsaken merged commit ac0ec33 into hyperledger-iroha:main Oct 25, 2024
9 of 12 checks passed
@BAStos525 BAStos525 deleted the ci/i2-gcov-sonar-flag branch October 25, 2024 13:36
@alexstroke1 alexstroke1 self-assigned this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s8sato s8sato Awaiting requested review from s8sato s8sato is a code owner

@mversic mversic Awaiting requested review from mversic mversic is a code owner

@SamHSmith SamHSmith Awaiting requested review from SamHSmith SamHSmith is a code owner

@outoftardis outoftardis Awaiting requested review from outoftardis outoftardis is a code owner

@0x009922 0x009922 Awaiting requested review from 0x009922 0x009922 is a code owner

@DCNick3 DCNick3 Awaiting requested review from DCNick3

@dima74 dima74 Awaiting requested review from dima74 dima74 is a code owner

Assignees

@BAStos525 BAStos525

@alexstroke1 alexstroke1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BAStos525 @nxsaken @alexstroke1