chore: move tests to separate repo #5203
Conversation
mversic
requested review from
s8sato,
SamHSmith,
0x009922 and
dima74
as code owners
mversic
force-pushed
the
move_integration_test
branch
2 times, most recently
from
6324385
to
5f4b5db
Compare
tests/status_response.rs
Outdated
There was a problem hiding this comment.
I'm not sure what to do about these tests. IMO tests should be reflect real use cases because their point is to mimick what a user would do. Therefore, a test cannot depend on iroha_telemetry.
A question that comes out of this is why would we support returning SCALE encoded status. This should just be Json
There was a problem hiding this comment.
I've come to understand this was the reason to implement SCALE encoding for the /status http request. I'm not particularly thrilled by this
There was a problem hiding this comment.
I've decided to remove this test
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
mversic
force-pushed
the
move_integration_test
branch
6 times, most recently
from
a4b8c08
to
df808b1
Compare
| @@ -3,14 +3,14 @@ set -e | |||
|
|
|||
| case $1 in | |||
| "genesis") | |||
| cargo run --release --bin kagami -- genesis generate --executor executor.wasm --wasm-dir libs --genesis-public-key ed01204164BF554923ECE1FD412D241036D863A6AE430476C898248B8237D77534CFC4 | diff - defaults/genesis.json || { | |||
| echo 'Please re-generate the default genesis with `cargo run --release --bin kagami -- genesis --executor executor.wasm --wasm-dir libs --genesis-public-key ed01204164BF554923ECE1FD412D241036D863A6AE430476C898248B8237D77534CFC4 > ./defaults/genesis.json`' | |||
| cargo run --package iroha_kagami --bin kagami --release -- genesis generate --executor executor.wasm --wasm-dir libs --genesis-public-key ed01204164BF554923ECE1FD412D241036D863A6AE430476C898248B8237D77534CFC4 | diff - defaults/genesis.json || { | |||
There was a problem hiding this comment.
it seems that the unfortunate consequence of defining a root crate iroha_tests now hinders our use of cargo run --bin. This is quite weird
mversic
force-pushed
the
move_integration_test
branch
3 times, most recently
from
510ba43
to
211e782
Compare
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
mversic
force-pushed
the
move_integration_test
branch
from
211e782
to
a011f75
Compare
This PR moves integration tests from
irohato a separate root crate.Finally, integration tests no longer have
transparent_apienabled.This has also uncovered dependency of tests on some questionable crate like
iroha_telemetryAlso I've followed up on #5113 which didn't include triggers and smart contracts
closes #5168