Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Don't use spinner when building wasm on CI #5208

Merged
merged 1 commit into from
Oct 30, 2024
Merged

fix: Don't use spinner when building wasm on CI #5208

merged 1 commit into from
Oct 30, 2024

Conversation

dima74
Copy link
Contributor

@dima74 dima74 commented Oct 30, 2024

Context

Fixes #5205

Checklist

  • I've read CONTRIBUTING.md.
  • (optional) I've written unit tests for the code changes.
  • All review comments have been resolved.
  • All CI checks pass.

@dima74
fix: Don't use spinner when building wasm on CI
1c0969c 
Signed-off-by: Dmitry Murzin <diralik@yandex.ru>
@dima74 dima74 self-assigned this Oct 30, 2024
@dima74 dima74 marked this pull request as ready for review October 30, 2024 12:42
@mversic mversic merged commit 15778b2 into hyperledger-iroha:main Oct 30, 2024
12 checks passed
@dima74 dima74 deleted the diralik/ci-wasm-build-no-spinner branch October 30, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mversic mversic mversic approved these changes

@s8sato s8sato s8sato approved these changes

@SamHSmith SamHSmith Awaiting requested review from SamHSmith SamHSmith is a code owner

@0x009922 0x009922 Awaiting requested review from 0x009922 0x009922 is a code owner

Assignees

@dima74 dima74

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

repeated 010010 Optimizing the output
3 participants
@dima74 @mversic @s8sato