Script fix to run a Geth Node #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ILoomans
changed the title
|
@conor10 @iikirilov Let me know when you have a chance to review this! I think it would be a useful fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the issue of starting a GETH Node using @EVMTest(NodeType.GETH). It updates the geth cli commands to be compatible with GETH version used
Updates include
--rpc flag became --http flag
-- rpcaddr became --http.addr
-- nousb is deprecated
Set --miner.etherbase
Where should the reviewer start?
Please look at the updates in the script files
Why is it needed?
In order to solve issues such as this: Issue