Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Private Transaction no longer serialise correctly since 4.9.0 #1747

Closed
antonydenyer opened this issue Jul 12, 2022 · 0 comments · Fixed by #1748
Closed

Private Transaction no longer serialise correctly since 4.9.0 #1747

antonydenyer opened this issue Jul 12, 2022 · 0 comments · Fixed by #1748
Labels
bug A bug in behaviour or functionality

Comments

@antonydenyer
Copy link
Contributor

Private Transactions are not serialized correctly

Since #1602 the PrivateTransactionEncoder was removed. You can not work around the problem as you are not able to specify you're own implementation where instantiating a PrivateTransactionManager (https://github.com/web3j/web3j/blob/master/besu/src/main/java/org/web3j/tx/PrivateTransactionManager.java#L83=).

There are a few ways to solve this. Either delegate serialization of the transaction to class (ie PrivateRawTransaction and PrivateTransaction),have another implementation of TxSignServiceImpl for private transactions, allow the TransactionEncoder to be specified during the creation of TxSignServiceImpl or something I haven't thought of!

Environment

  • Web3j 4.9.0
  • Java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A bug in behaviour or functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix private transaction manager antonydenyer/web3j
1 participant
@antonydenyer