Upgrade Web3J #3752

diega · 2022-04-22T12:56:20Z

ON HOLD: waiting for org.web3j:quorum release (ref: web3j-quorum#66)

Update Web3J dependency

This PR also reverts #3789

Signed-off-by: Diego López León dieguitoll@gmail.com

Documentation

I thought about documentation and added the doc-change-required label to this PR if
updates are required.

Changelog

I thought about the changelog and included a changelog update if required.

sonarcloud · 2022-05-11T12:54:43Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

diega · 2022-07-12T13:41:06Z

@antonydenyer to move this PR to 4.9.3 we are missing org.web3j:quorum which is on 4.9.0. Also the web3j-gradle-plugin would be great if can be moved to 4.9.3 (it's on 4.9.2). Should I fill an issue in the respective projects?
This would be an attempt to check if we can make the acceptanceTests to pass using those versions

antonydenyer · 2022-07-12T14:33:35Z

@antonydenyer to move this PR to 4.9.3 we are missing org.web3j:quorum which is on 4.9.0. Also the web3j-gradle-plugin would be great if can be moved to 4.9.3 (it's on 4.9.2). Should I fill an issue in the respective projects? This would be an attempt to check if we can make the acceptanceTests to pass using those versions

I think raising an issue in the respective projects would make sense.

I'm happy to have a look at the acceptanceTests first, before looking at the version inconsistencies.

I think we should be able to use everything on to 4.9.3 and have org.web3j:quorum and web3j-gradle-plugin forced to use the 4.9.3 dependencies bit life would be a lot easier if upstream libraries were updated.

antonydenyer · 2022-07-12T20:03:29Z

Blocked by hyperledger-web3j/web3j#1747

diega · 2022-07-19T20:10:09Z

While we wait for a release of the web3j components to fix the acceptanceTests, I tried to force the dependencies as suggested.
For org.web3j:quorum it seems to possible by using constraints, but web3j-gradle-plugin forces the inclusion of the org.web3:core:$projectVersion dependency programmatically (see o.w.g.p.Web3jPlugin:49) so we end up using both versions during the build/test cycle. Fortunately this is not so terrible as both cycles have different classpaths, at build v4.9.0 will be used just for the plugin, and at runtime +v4.9.0 will be used for any other project usage.

Signed-off-by: Diego López León <dieguitoll@gmail.com>

This reverts commit baed1ef. Signed-off-by: Diego López León <dieguitoll@gmail.com>

Signed-off-by: Antony Denyer <git@antonydenyer.co.uk>

Use strictly to force the issue. Signed-off-by: Antony Denyer <git@antonydenyer.co.uk>

antonydenyer · 2022-07-26T10:35:08Z

@diega Had to force the dependency in the end! I think this is ready for review now.

antonydenyer · 2022-07-26T12:04:27Z

acceptance-tests/dsl/src/main/java/org/hyperledger/besu/tests/acceptance/dsl/BlockUtils.java

@@ -50,7 +52,7 @@ public static BlockHeader createBlockHeader(
        Bytes.fromHexString(block.getExtraData()),
        null,
        mixHash,
-        block.getNonce().longValue(),
+        new BigInteger(block.getNonceRaw().substring(2), 16).longValue(),


hyperledger-web3j/web3j#1752

diega · 2022-07-26T12:39:06Z

@antonydenyer nice trick! that way you'll be overriding the dependency added programmatically by the plugin, right?

antonydenyer · 2022-07-26T12:56:02Z

@antonydenyer nice trick! that way you'll be overriding the dependency added programmatically by the plugin, right?

More like a sledgehammer that overrides everything - it will force everything to use '4.9.4', this could be a problem when you come to upgrade again. You could change the version in versions.gradle but it would have no affect. Perhaps we should use @freemanzMrojo approach as it has a little more finesse and may be easier for someone to spot. What do you think?

shemnon · 2022-07-26T14:46:04Z

acceptance-tests/tests/build.gradle

+  implementation('org.web3j:core') {
+    version {
+      strictly('4.9.4')
+      because('web3j plugin 4.9.4 hasn\'t been released yet')


Suggested change

because('web3j plugin 4.9.4 hasn\'t been released yet')

because('Plugin version is 4.9.2 (latest), but we want it to use web3j libs version 4.9.4 ')

shemnon · 2022-07-26T14:47:12Z

container-tests/tests/build.gradle

-  testImplementation 'org.web3j:quorum'
+  testImplementation('org.web3j:quorum') {
+    constraints {
+      implementation('org.web3j:core:4.9.4') { because 'quorum 4.9.4 hasn\'t been released yet' }


Suggested change

implementation('org.web3j:core:4.9.4') { because 'quorum 4.9.4 hasn\'t been released yet' }

implementation('org.web3j:core:4.9.4') {

because 'Web3J/Quorum only has a 4.9.2 lib, but we want it to use web3j libs version 4.9.4 ')

}

…n dependencies Signed-off-by: Miguel Rojo <miguelangel.rojofernandez@mastercard.com>

freemanzMrojo · 2022-07-29T10:52:57Z

Hi @antonydenyer @shemnon , hope you are doing well, and happy Friday! I was wondering if there is anything else to do in this PR, otherwise maybe you could merge it? I need it for #4086, thanks in advance!

shemnon · 2022-08-01T16:00:03Z

I'm holding off for 22.7.0 to ship as this is not essential to the merge.

* Upgrade web3j dependencies to latest versions Signed-off-by: Diego López León <dieguitoll@gmail.com> Signed-off-by: Antony Denyer <git@antonydenyer.co.uk> Co-authored-by: Antony Denyer <git@antonydenyer.co.uk> Co-authored-by: Miguel Rojo <miguelangel.rojofernandez@mastercard.com> Co-authored-by: Miguel Angel Rojo <freemanz1486@gmail.com>

* Upgrade web3j dependencies to latest versions Signed-off-by: Diego López León <dieguitoll@gmail.com> Signed-off-by: Antony Denyer <git@antonydenyer.co.uk> Co-authored-by: Antony Denyer <git@antonydenyer.co.uk> Co-authored-by: Miguel Rojo <miguelangel.rojofernandez@mastercard.com> Co-authored-by: Miguel Angel Rojo <freemanz1486@gmail.com> Signed-off-by: Cody Born <codyborn@outlook.com>

* Upgrade web3j dependencies to latest versions Signed-off-by: Diego López León <dieguitoll@gmail.com> Signed-off-by: Antony Denyer <git@antonydenyer.co.uk> Co-authored-by: Antony Denyer <git@antonydenyer.co.uk> Co-authored-by: Miguel Rojo <miguelangel.rojofernandez@mastercard.com> Co-authored-by: Miguel Angel Rojo <freemanz1486@gmail.com>

diega marked this pull request as draft April 22, 2022 13:30

diega force-pushed the bump_web3j branch from 99df789 to 9889764 Compare April 22, 2022 15:51

diega mentioned this pull request Apr 22, 2022

Add IPC transport for JSON-RPC APIs #3695

Merged

2 tasks

diega force-pushed the bump_web3j branch 2 times, most recently from 6afbac1 to 6c405ea Compare May 11, 2022 12:32

diega added the mainnet label May 29, 2022

antonydenyer mentioned this pull request Jul 12, 2022

Enclave public key length constraint removed for private transactions #4086

Merged

antonydenyer force-pushed the bump_web3j branch 3 times, most recently from 6c91d4a to f90b33e Compare July 12, 2022 12:57

diega force-pushed the bump_web3j branch from f90b33e to ec28dce Compare July 12, 2022 13:20

diega force-pushed the bump_web3j branch from ec28dce to 62d3975 Compare July 19, 2022 20:35

diega changed the title ~~Web3J 4.9.0~~ Upgrade Web3J Jul 19, 2022

diega added 2 commits July 20, 2022 11:16

Upgrade web3j dependencies to latest versions

94462a6

Signed-off-by: Diego López León <dieguitoll@gmail.com>

Revert "add constraint for jnr-posix dependency (hyperledger#3789)"

3f7bba2

This reverts commit baed1ef. Signed-off-by: Diego López León <dieguitoll@gmail.com>

diega force-pushed the bump_web3j branch from 62d3975 to 3f7bba2 Compare July 20, 2022 14:16

antonydenyer added 2 commits July 21, 2022 22:22

4.9.4 released

cff5c61

Signed-off-by: Antony Denyer <git@antonydenyer.co.uk>

Force web3j plugin to resolve dependencies to 4.9.4

6f735e1

Signed-off-by: Antony Denyer <git@antonydenyer.co.uk>

antonydenyer force-pushed the bump_web3j branch from c0593df to 6f735e1 Compare July 22, 2022 09:09

Work around nonce decoding issue on clique with zero padded nonce

d6ca11c

Signed-off-by: Antony Denyer <git@antonydenyer.co.uk>

antonydenyer force-pushed the bump_web3j branch 2 times, most recently from 2e2de4c to 5033283 Compare July 26, 2022 09:10

diega marked this pull request as ready for review July 26, 2022 09:39

A transitive dependency is still sneaking in somehow

6b4121d

Use strictly to force the issue. Signed-off-by: Antony Denyer <git@antonydenyer.co.uk>

antonydenyer force-pushed the bump_web3j branch from 5033283 to 6b4121d Compare July 26, 2022 10:00

Merge branch 'main' into bump_web3j

db1e9ba

antonydenyer reviewed Jul 26, 2022

View reviewed changes

shemnon reviewed Jul 26, 2022

View reviewed changes

freemanzMrojo and others added 6 commits July 26, 2022 16:11

using resolutionStrategy to enforce the use of v4.9.4 for web3j plugi…

7b556a3

…n dependencies Signed-off-by: Miguel Rojo <miguelangel.rojofernandez@mastercard.com>

Merge branch 'main' into bump_web3j

0bb8625

Merge branch 'main' into bump_web3j

a7b7b9f

Merge branch 'main' into bump_web3j

7047144

Merge branch 'main' into bump_web3j

8ef49b4

Merge branch 'main' into bump_web3j

0c92ba4

antonydenyer approved these changes Jul 28, 2022

View reviewed changes

freemanzMrojo added 2 commits July 28, 2022 13:40

Merge branch 'main' into bump_web3j

67c59ae

Merge branch 'main' into bump_web3j

b38b530

freemanzMrojo and others added 3 commits July 29, 2022 16:37

Merge branch 'main' into bump_web3j

cc14c27

Merge branch 'main' into bump_web3j

88f7e00

Merge branch 'main' into bump_web3j

0855871

freemanzMrojo added 3 commits August 2, 2022 19:25

Merge branch 'main' into bump_web3j

9e6d9a8

Merge branch 'main' into bump_web3j

dda0651

Merge branch 'main' into bump_web3j

ba1410f

shemnon merged commit 98dc2ac into hyperledger:main Aug 4, 2022

diega deleted the bump_web3j branch August 29, 2022 15:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade Web3J #3752

Upgrade Web3J #3752

diega commented Apr 22, 2022 •

edited

Loading

sonarcloud bot commented May 11, 2022

diega commented Jul 12, 2022

antonydenyer commented Jul 12, 2022

antonydenyer commented Jul 12, 2022

diega commented Jul 19, 2022

antonydenyer commented Jul 26, 2022

antonydenyer Jul 26, 2022

diega commented Jul 26, 2022

antonydenyer commented Jul 26, 2022 •

edited

Loading

shemnon Jul 26, 2022

shemnon Jul 26, 2022

freemanzMrojo commented Jul 29, 2022

shemnon commented Aug 1, 2022

	because('web3j plugin 4.9.4 hasn\'t been released yet')
	because('Plugin version is 4.9.2 (latest), but we want it to use web3j libs version 4.9.4 ')

Upgrade Web3J #3752

Upgrade Web3J #3752

Conversation

diega commented Apr 22, 2022 • edited Loading

Documentation

Changelog

sonarcloud bot commented May 11, 2022

diega commented Jul 12, 2022

antonydenyer commented Jul 12, 2022

antonydenyer commented Jul 12, 2022

diega commented Jul 19, 2022

antonydenyer commented Jul 26, 2022

antonydenyer Jul 26, 2022

Choose a reason for hiding this comment

diega commented Jul 26, 2022

antonydenyer commented Jul 26, 2022 • edited Loading

shemnon Jul 26, 2022

Choose a reason for hiding this comment

shemnon Jul 26, 2022

Choose a reason for hiding this comment

freemanzMrojo commented Jul 29, 2022

shemnon commented Aug 1, 2022

diega commented Apr 22, 2022 •

edited

Loading

antonydenyer commented Jul 26, 2022 •

edited

Loading