Structs arrays support #1321

rach-id · 2020-12-31T02:25:56Z

What does this PR do?

Adds support for:

Arrays of structs
Multiple structs returns

Where should the reviewer start?

Abi encoder/decoder and check the encoding formal specification

Why is it needed?

More and more users are using structs in their Solidity smart contracts

iikirilov-wmt · 2020-12-31T08:54:44Z

test coverage looks good - needs a spotless apply

rach-id · 2020-12-31T09:31:10Z

Still needs more encoding tests with different functions and also codegen module update to generate arrays of structs code.

rach-id · 2021-01-04T21:59:12Z

Limitation

abi/src/main/java/org/web3j/abi/DefaultFunctionEncoder.java

abi/src/main/java/org/web3j/abi/Utils.java

* adds structs arrays fixtures to AbiV2TestFixture * Adds necessary AbiV2 functions for testing * Adds Abi Decoder tests * Adds Structs array + multiple structs returns decoder * fixes String padded length size * adds type name return for structs when getting simple name * Adds structs encoder tests * Adds structs encoder * adds struct type to AbiTypes * imports cleanup * spotless * Utils refactor * fix array of structs creation by the decoder * fix structs array encoding * imports fix * add support for array of structs wrapper generation * make the convert to native function support arrays of structs * add getTypeAsString java doc * fix getTypeAsString to support structs arrays * add encoder structs array tests * add codegen structs array wrapper generation test * cosmetics * spotless + cosmetics * suppress warnings + remove unnecessary sout * suppress warnings + remove unnecessary sout * update ComplexStorage.sol to use arrays of structs * cosmetics * fixes dynamic byte arrays prefixed their length encoding in structs. * structs dynamic values tweak + add tests for dynamic struct containing dynamic bytes array * fixes encoding of array strings + adds tests * fixes byte types padded length * cosmetics * spotless * fix isParametrizedTypeStaticStruct * remove unnecessary function * fixes dynamic type in static array + adds tests * adds more encoder tests * fixes static array with static struct decoder * adds static/dynamic array with static struct encoder test * suppress warnings + java docs + cosmetics * javadocs + spotless

874341642 · 2022-06-12T02:57:22Z

What does this PR do?

Adds support for:

abi

"outputs": [{
"components": [ {
"internalType": "uint256[]",
"name": "blocks",
"type": "uint256[]"
}],
"internalType": "struct Mining.PlayerWork",
"name": "",
"type": "tuple"
}]

java

public PlayerWork(DynamicArray< Uint256 > blocks) {
super(blocks);
}

Error info

java.lang.UnsupportedOperationException: Array types must be wrapped in a TypeReference

Bug?Bug?Bug?Bug?Bug?Bug?Bug?Bug?

rach-id · 2022-06-12T03:26:28Z

@874341642 Please open a new issue with this case, and provide more information on solidity version, compiler used etc.
I personally don't think I will have time to pick this up in upcoming months. But, if somebody else did, I would be happy to provide context and review.

874341642 · 2022-06-12T04:08:07Z

The tuple contains arrays, what do I need to do to solve this problem?

@874341642 Please open a new issue with this case, and provide more information on solidity version, compiler used etc. I personally don't think I will have time to pick this up in upcoming months. But, if somebody else did, I would be happy to provide context and review.

The tuple contains arrays, what do I need to do to solve this problem?

874341642 · 2022-06-12T04:55:04Z

@874341642 Please open a new issue with this case, and provide more information on solidity version, compiler used etc. I personally don't think I will have time to pick this up in upcoming months. But, if somebody else did, I would be happy to provide context and review.

Please help me

tonghoang196 · 2022-10-29T12:56:37Z

when is this included in the new version? I am using this dependency

<dependency>
    <groupId>org.web3j</groupId>
    <artifactId>core</artifactId>
    <version>4.9.4</version>
</dependency>

and web3j version: Version: 1.4.2, still have error Unsupported type encountered: tuple

rach-id added 9 commits December 18, 2020 16:46

adds structs arrays fixtures to AbiV2TestFixture

e6ed967

Adds necessary AbiV2 functions for testing

b37456b

Adds Abi Decoder tests

6243000

Adds Structs array + multiple structs returns decoder

79c32fb

fixes String padded length size

3f51e1c

adds type name return for structs when getting simple name

f5b57b5

Adds structs encoder tests

aa22797

Adds structs encoder

c63e25e

adds struct type to AbiTypes

1d88507

rach-id requested review from conor10 and iikirilov as code owners December 31, 2020 02:25

rach-id marked this pull request as draft December 31, 2020 02:26

imports cleanup

6be499c

rach-id added 15 commits December 31, 2020 17:38

spotless

ef2741b

Utils refactor

07f5e4e

fix array of structs creation by the decoder

6dcff6a

fix structs array encoding

7ce940c

imports fix

92c690c

add support for array of structs wrapper generation

c350b79

make the convert to native function support arrays of structs

9d403f0

add getTypeAsString java doc

514bc93

fix getTypeAsString to support structs arrays

cd43340

add encoder structs array tests

b218a5c

add codegen structs array wrapper generation test

ab8405e

cosmetics

43853b0

spotless + cosmetics

d66b23d

suppress warnings + remove unnecessary sout

0d049fc

suppress warnings + remove unnecessary sout

562aa2a

fixes encoding of array strings + adds tests

8f7a675

rach-id mentioned this pull request Jan 4, 2021

Utf8String DynamicArray is decoded incorrectly #1278

Closed

rach-id added 2 commits January 4, 2021 19:46

fixes byte types padded length

7988f97

cosmetics

a23f9c6

This was referenced Jan 4, 2021

ABI v2 decoder cannot decode struct containing bytes32. #1257

Closed

FunctionReturnDecoder returns incorrect result when decoding string[] #1251

Closed

Using outputParameters to decode "string[]" return type failed #1236

Closed

spotless

d287a7f

rach-id added 3 commits January 6, 2021 17:15

fix isParametrizedTypeStaticStruct

06f60e5

remove unnecessary function

a7d4bfe

fixes dynamic type in static array + adds tests

3c7e3dc

xaviarias reviewed Jan 8, 2021

View reviewed changes

abi/src/main/java/org/web3j/abi/DefaultFunctionEncoder.java Outdated Show resolved Hide resolved

abi/src/main/java/org/web3j/abi/Utils.java Outdated Show resolved Hide resolved

rach-id added 5 commits January 8, 2021 14:38

adds more encoder tests

2ed0b2d

fixes static array with static struct decoder

cb600f3

adds static/dynamic array with static struct encoder test

a3216b2

suppress warnings + java docs + cosmetics

39c3b1f

javadocs + spotless

e21005d

xaviarias approved these changes Jan 8, 2021

View reviewed changes

xaviarias merged commit 87d2446 into hyperledger-web3j:master Jan 8, 2021

rach-id deleted the structs_arrays_support branch June 12, 2022 03:26

rach-id mentioned this pull request Jun 12, 2022

Handle ABI V2 nested array case #1726

Closed

rach-id mentioned this pull request Oct 10, 2022

Unsupported type encountered: tuple when trying to create contract wrapper #1361

Closed

Gelassen mentioned this pull request Feb 2, 2023

Get StringIndexOutOfBoundsException when receive result as a dynamic array with single struct #1858

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Structs arrays support #1321

Structs arrays support #1321

rach-id commented Dec 31, 2020

iikirilov-wmt commented Dec 31, 2020

rach-id commented Dec 31, 2020 •

edited

Loading

rach-id commented Jan 4, 2021

874341642 commented Jun 12, 2022 •

edited

Loading

What does this PR do?

rach-id commented Jun 12, 2022 •

edited

Loading

874341642 commented Jun 12, 2022

874341642 commented Jun 12, 2022

tonghoang196 commented Oct 29, 2022 •

edited

Loading

Structs arrays support #1321

Structs arrays support #1321

Conversation

rach-id commented Dec 31, 2020

What does this PR do?

Where should the reviewer start?

Why is it needed?

iikirilov-wmt commented Dec 31, 2020

rach-id commented Dec 31, 2020 • edited Loading

rach-id commented Jan 4, 2021

874341642 commented Jun 12, 2022 • edited Loading

What does this PR do?

abi

"outputs": [{ "components": [ { "internalType": "uint256[]", "name": "blocks", "type": "uint256[]" }], "internalType": "struct Mining.PlayerWork", "name": "", "type": "tuple" }]

java

public PlayerWork(DynamicArray< Uint256 > blocks) { super(blocks); }

Error info

java.lang.UnsupportedOperationException: Array types must be wrapped in a TypeReference

rach-id commented Jun 12, 2022 • edited Loading

874341642 commented Jun 12, 2022

874341642 commented Jun 12, 2022

tonghoang196 commented Oct 29, 2022 • edited Loading

rach-id commented Dec 31, 2020 •

edited

Loading

874341642 commented Jun 12, 2022 •

edited

Loading

"outputs": [{
"components": [ {
"internalType": "uint256[]",
"name": "blocks",
"type": "uint256[]"
}],
"internalType": "struct Mining.PlayerWork",
"name": "",
"type": "tuple"
}]

public PlayerWork(DynamicArray< Uint256 > blocks) {
super(blocks);
}

rach-id commented Jun 12, 2022 •

edited

Loading

tonghoang196 commented Oct 29, 2022 •

edited

Loading