Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Return IndyVdr based CredentialDefinition schemaId as full schemaId (not sequence number) #1313

Merged

Conversation

gmulhearn
Copy link
Contributor

@gmulhearn gmulhearn commented Dec 13, 2024

indy ledgers will return creddef.schemaId as seqNo sometimes (see related openwallet-foundation/acapy#220 older acapy discussion), this is not a valid anoncreds schemaId, and is not consumer friendly.

This fix adds an extra ledger call (if necessary) to convert from schema seqNo to schemaId by resolving the raw txn and extracting the data. This matches acapy & credo's strategy:

credo-ts:

acapy:

Signed-off-by: George Mulhearn <gmulhearn@anonyome.com>
JamesKEbert
JamesKEbert previously approved these changes Dec 13, 2024
aries/aries_vcx_ledger/src/ledger/indy_vdr_ledger.rs Outdated Show resolved Hide resolved
Co-authored-by: James Ebert  <JamesEbert.k@gmail.com>
Signed-off-by: gmulhearn-anonyome <90162009+gmulhearn-anonyome@users.noreply.github.com>
@JamesKEbert
Copy link
Contributor

Would a GH issue be appropriate on the ACA-Py side about this (given that we're adjusting it and Credo already has this behavior)?

@gmulhearn
Copy link
Contributor Author

@JamesKEbert thnx for review. And yea acapy issue probably a good idea to re-discuss with them. Although I should probably re-test that it still occurs, my testing environment where it was happening a few months ago might be dated

@gmulhearn gmulhearn merged commit cf43869 into hyperledger:main Dec 13, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants