Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python version bump #1324

Merged
merged 1 commit into from
May 10, 2023
Merged

python version bump #1324

merged 1 commit into from
May 10, 2023

Conversation

macfarla
Copy link
Contributor

Projects using read the docs: you need to update your .readthedocs.yml to look like this: https://github.com/hyperledger/cacti/blob/10746c3e65891dfa38658d9ecae631222b92fddd/.readthedocs.yaml urllib released which broke previous configs. readthedocs/readthedocs.org#10290 https://www.reddit.com/r/technicalwriting/comments/138rxms/readthedocs_sphinx_theme_urllib3_related_build/

For content changes:

  • Documentation content
  • Documentation page organization

For tool changes:

  • Github Actions workflow
  • Build and QA tools configuration (for example, lint rules or Vale style)
  • MkDocs templates
  • MkDocs configuration
  • Python dependencies
  • Node dependencies and JavaScript
  • Read the Docs configuration
  • GitHub integration

After creating your PR and tests have finished

Make sure that:

Preview

@macfarla
python version bump
e7e46e9 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla macfarla requested a review from a team as a code owner May 10, 2023 03:46
siladu
siladu approved these changes May 10, 2023
View reviewed changes
Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macfarla macfarla merged commit d8d6b06 into hyperledger:main May 10, 2023
@macfarla macfarla deleted the python-update branch May 11, 2023 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandratran alexandratran alexandratran approved these changes

@siladu siladu siladu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@macfarla @siladu @alexandratran