Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1394 doc eth get block receipts api method #1413

Conversation

mjsmike62
Copy link
Contributor

@mjsmike62 mjsmike62 commented Oct 5, 2023

Documented the eth_getBlockReceipts API method in the Besu API methods/ETH methods section of the public Besu documentation.

Fixes: #1394

See: https://besu-docs-aploqe3ms-hyperledger.vercel.app/development/public-networks/reference/api#eth_getblockreceipts

Signed-off-by: Mike Sanko <mike.sanko@consensys.net>
Signed-off-by: Mike Sanko <mike.sanko@consensys.net>
@mjsmike62 mjsmike62 requested a review from a team as a code owner October 5, 2023 16:03
@vercel
Copy link

vercel bot commented Oct 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
besu-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2023 4:24pm

@matthew1001
Copy link
Contributor

This looks good to me @mjsmike62, thanks

Copy link
Contributor

@alexandratran alexandratran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added two change suggestions. Again, you can go to Files changed, and for each suggestion, Add suggestion to batch, then commit the suggestions directly in GH.

docs/public-networks/reference/api/index.md Outdated Show resolved Hide resolved
docs/public-networks/reference/api/index.md Outdated Show resolved Hide resolved
docs/public-networks/reference/api/index.md Outdated Show resolved Hide resolved
docs/public-networks/reference/api/index.md Outdated Show resolved Hide resolved
docs/public-networks/reference/api/index.md Outdated Show resolved Hide resolved
Signed-off-by: Mike Sanko <mike.sanko@consensys.net>
Signed-off-by: Mike Sanko <mike.sanko@consensys.net>
…:mjsmike62/besu-docs into 1394-doc-eth_getBlockReceipts-API-method
Signed-off-by: Mike Sanko <mike.sanko@consensys.net>
Signed-off-by: Mike Sanko <mike.sanko@consensys.net>
Signed-off-by: Mike Sanko <mike.sanko@consensys.net>
Signed-off-by: Mike Sanko <mike.sanko@consensys.net>
Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a few issues including the reversion of a previously resolved one. Also, for some reason I can't see eth_getBlockReceipts in the latest preview: https://besu-docs-pck4y18td-hyperledger.vercel.app/public-networks/reference/api

docs/public-networks/reference/api/index.md Outdated Show resolved Hide resolved
docs/public-networks/reference/api/index.md Outdated Show resolved Hide resolved
docs/public-networks/reference/api/index.md Outdated Show resolved Hide resolved
docs/public-networks/reference/api/index.md Outdated Show resolved Hide resolved
Signed-off-by: Mike Sanko <mike.sanko@consensys.net>
…:mjsmike62/besu-docs into 1394-doc-eth_getBlockReceipts-API-method
Signed-off-by: Mike Sanko <mike.sanko@consensys.net>
Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple more things. This is the reverted issue I mentioned: https://github.com/hyperledger/besu-docs/pull/1413/files#r1376752181

docs/public-networks/reference/api/index.md Outdated Show resolved Hide resolved
docs/public-networks/reference/api/index.md Outdated Show resolved Hide resolved
docs/public-networks/reference/api/index.md Outdated Show resolved Hide resolved
Signed-off-by: Mike Sanko <mike.sanko@consensys.net>
Signed-off-by: Mike Sanko <mike.sanko@consensys.net>
Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@alexandratran alexandratran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexandratran alexandratran merged commit 7ae75fc into hyperledger:main Nov 1, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document the eth_getBlockReceipts() API metrhod
4 participants