-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1394 doc eth get block receipts api method #1413
1394 doc eth get block receipts api method #1413
Conversation
Signed-off-by: Mike Sanko <mike.sanko@consensys.net>
Signed-off-by: Mike Sanko <mike.sanko@consensys.net>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This looks good to me @mjsmike62, thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added two change suggestions. Again, you can go to Files changed, and for each suggestion, Add suggestion to batch, then commit the suggestions directly in GH.
Signed-off-by: Mike Sanko <mike.sanko@consensys.net>
Signed-off-by: Mike Sanko <mike.sanko@consensys.net>
…:mjsmike62/besu-docs into 1394-doc-eth_getBlockReceipts-API-method
Signed-off-by: Mike Sanko <mike.sanko@consensys.net>
Signed-off-by: Mike Sanko <mike.sanko@consensys.net>
Signed-off-by: Mike Sanko <mike.sanko@consensys.net>
Signed-off-by: Mike Sanko <mike.sanko@consensys.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a few issues including the reversion of a previously resolved one. Also, for some reason I can't see eth_getBlockReceipts in the latest preview: https://besu-docs-pck4y18td-hyperledger.vercel.app/public-networks/reference/api
Signed-off-by: Mike Sanko <mike.sanko@consensys.net>
…:mjsmike62/besu-docs into 1394-doc-eth_getBlockReceipts-API-method
Signed-off-by: Mike Sanko <mike.sanko@consensys.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple more things. This is the reverted issue I mentioned: https://github.com/hyperledger/besu-docs/pull/1413/files#r1376752181
Signed-off-by: Mike Sanko <mike.sanko@consensys.net>
Signed-off-by: Mike Sanko <mike.sanko@consensys.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Documented the
eth_getBlockReceipts
API method in the Besu API methods/ETH methods section of the public Besu documentation.Fixes: #1394
See: https://besu-docs-aploqe3ms-hyperledger.vercel.app/development/public-networks/reference/api#eth_getblockreceipts