Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pruning-block-confirmations and pruning-blocks-retained options documented #242

Merged
merged 16 commits into from
Mar 20, 2020
Merged

pruning-block-confirmations and pruning-blocks-retained options documented #242

merged 16 commits into from
Mar 20, 2020

Conversation

grantnoble
Copy link

Documented as per hyperledger/besu#440

Grant Noble added 8 commits February 20, 2020 09:51
Update my forked repo with changes from head repo
Merge hyperledger/besu-docs into my fork
Added plugins_reloadPluginConfig (#184)
Update fork with latest from head repo
Update grantnoble fork with lasted on head
Update grantnoble fork with hyperledger master repo
Update grantnoble/besu-docs from hyperledger/besu-docs
…ented

Signed-off-by: grantnoble <grant.noble@consensys.net>
pruning-block-confirmations=5
```

The minimum number of confirmations on a block before marking begins. The default is 10.
Copy link
Contributor

@NicolasMassart NicolasMassart Mar 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is marking? Can you confirm it's the right word and if so, can you explain it?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spoke with Abdel about this and have updated the description.

Copy link

@AbdelStark AbdelStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Grant Noble added 2 commits March 20, 2020 11:15
Signed-off-by: grantnoble <grant.noble@consensys.net>
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@grantnoble grantnoble merged commit 7d4662a into hyperledger:master Mar 20, 2020
@grantnoble grantnoble deleted the grantnoble-pruning-blocks branch March 20, 2020 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants