migrate clique tests fully to junit5 (#6362)

* migrate clique tests fully to junit5 Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
hyperledger · Jan 8, 2024 · ebea425 · ebea425
1 parent 658d153
commit ebea425
Show file tree

Hide file tree

Showing 6 changed files with 22 additions and 22 deletions.
diff --git a/...est/java/org/hyperledger/besu/tests/acceptance/clique/CliqueDiscardRpcAcceptanceTest.java b/...est/java/org/hyperledger/besu/tests/acceptance/clique/CliqueDiscardRpcAcceptanceTest.java
@@ -14,14 +14,14 @@
  */
 package org.hyperledger.besu.tests.acceptance.clique;
 
-import org.hyperledger.besu.tests.acceptance.dsl.AcceptanceTestBase;
+import org.hyperledger.besu.tests.acceptance.dsl.AcceptanceTestBaseJunit5;
 import org.hyperledger.besu.tests.acceptance.dsl.node.BesuNode;
 
 import java.io.IOException;
 
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
 
-public class CliqueDiscardRpcAcceptanceTest extends AcceptanceTestBase {
+public class CliqueDiscardRpcAcceptanceTest extends AcceptanceTestBaseJunit5 {
 
   @Test
   public void shouldDiscardVotes() throws IOException {

diff --git a/...tance/clique/CliqueGetSignersRpcTest.java → ...ue/CliqueGetSignersRpcAcceptanceTest.java b/...tance/clique/CliqueGetSignersRpcTest.java → ...ue/CliqueGetSignersRpcAcceptanceTest.java
@@ -16,19 +16,19 @@
 
 import static org.hyperledger.besu.tests.acceptance.dsl.transaction.clique.CliqueTransactions.LATEST;
 
-import org.hyperledger.besu.tests.acceptance.dsl.AcceptanceTestBase;
+import org.hyperledger.besu.tests.acceptance.dsl.AcceptanceTestBaseJunit5;
 import org.hyperledger.besu.tests.acceptance.dsl.node.BesuNode;
 
-import org.junit.Before;
-import org.junit.Ignore;
-import org.junit.Test;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Disabled;
+import org.junit.jupiter.api.Test;
 
-@Ignore
-public class CliqueGetSignersRpcTest extends AcceptanceTestBase {
+@Disabled("flaky test due to hardcoded block numbers")
+public class CliqueGetSignersRpcAcceptanceTest extends AcceptanceTestBaseJunit5 {
   private BesuNode minerNode1;
   private BesuNode minerNode2;
 
-  @Before
+  @BeforeEach
   public void setUp() throws Exception {
     final String[] validators = {"miner1"};
     minerNode1 = besu.createCliqueNodeWithValidators("miner1", validators);

diff --git a/...rc/test/java/org/hyperledger/besu/tests/acceptance/clique/CliqueMiningAcceptanceTest.java b/...rc/test/java/org/hyperledger/besu/tests/acceptance/clique/CliqueMiningAcceptanceTest.java
@@ -14,16 +14,16 @@
  */
 package org.hyperledger.besu.tests.acceptance.clique;
 
-import org.hyperledger.besu.tests.acceptance.dsl.AcceptanceTestBase;
+import org.hyperledger.besu.tests.acceptance.dsl.AcceptanceTestBaseJunit5;
 import org.hyperledger.besu.tests.acceptance.dsl.account.Account;
 import org.hyperledger.besu.tests.acceptance.dsl.node.BesuNode;
 import org.hyperledger.besu.tests.acceptance.dsl.node.configuration.genesis.GenesisConfigurationFactory.CliqueOptions;
 
 import java.io.IOException;
 
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
 
-public class CliqueMiningAcceptanceTest extends AcceptanceTestBase {
+public class CliqueMiningAcceptanceTest extends AcceptanceTestBaseJunit5 {
 
   @Test
   public void shouldMineTransactionsOnSingleNode() throws IOException {

diff --git a/...st/java/org/hyperledger/besu/tests/acceptance/clique/CliqueProposalRpcAcceptanceTest.java b/...st/java/org/hyperledger/besu/tests/acceptance/clique/CliqueProposalRpcAcceptanceTest.java
@@ -14,14 +14,14 @@
  */
 package org.hyperledger.besu.tests.acceptance.clique;
 
-import org.hyperledger.besu.tests.acceptance.dsl.AcceptanceTestBase;
+import org.hyperledger.besu.tests.acceptance.dsl.AcceptanceTestBaseJunit5;
 import org.hyperledger.besu.tests.acceptance.dsl.node.BesuNode;
 
 import java.io.IOException;
 
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
 
-public class CliqueProposalRpcAcceptanceTest extends AcceptanceTestBase {
+public class CliqueProposalRpcAcceptanceTest extends AcceptanceTestBaseJunit5 {
 
   @Test
   public void shouldReturnProposals() throws IOException {

diff --git a/...est/java/org/hyperledger/besu/tests/acceptance/clique/CliqueProposeRpcAcceptanceTest.java b/...est/java/org/hyperledger/besu/tests/acceptance/clique/CliqueProposeRpcAcceptanceTest.java
@@ -14,16 +14,16 @@
  */
 package org.hyperledger.besu.tests.acceptance.clique;
 
-import org.hyperledger.besu.tests.acceptance.dsl.AcceptanceTestBase;
+import org.hyperledger.besu.tests.acceptance.dsl.AcceptanceTestBaseJunit5;
 import org.hyperledger.besu.tests.acceptance.dsl.condition.Condition;
 import org.hyperledger.besu.tests.acceptance.dsl.condition.clique.ExpectNonceVote.CLIQUE_NONCE_VOTE;
 import org.hyperledger.besu.tests.acceptance.dsl.node.BesuNode;
 
 import java.io.IOException;
 
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
 
-public class CliqueProposeRpcAcceptanceTest extends AcceptanceTestBase {
+public class CliqueProposeRpcAcceptanceTest extends AcceptanceTestBaseJunit5 {
 
   @Test
   public void shouldAddValidators() throws IOException {

diff --git a/...ceptance/clique/CliqueZeroValidators.java → ...e/CliqueZeroValidatorsAcceptanceTest.java b/...ceptance/clique/CliqueZeroValidators.java → ...e/CliqueZeroValidatorsAcceptanceTest.java
@@ -14,14 +14,14 @@
  */
 package org.hyperledger.besu.tests.acceptance.clique;
 
-import org.hyperledger.besu.tests.acceptance.dsl.AcceptanceTestBase;
+import org.hyperledger.besu.tests.acceptance.dsl.AcceptanceTestBaseJunit5;
 import org.hyperledger.besu.tests.acceptance.dsl.node.BesuNode;
 
 import java.io.IOException;
 
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
 
-public class CliqueZeroValidators extends AcceptanceTestBase {
+public class CliqueZeroValidatorsAcceptanceTest extends AcceptanceTestBaseJunit5 {
 
   @Test
   public void zeroValidatorsFormValidCluster() throws IOException {