Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate coverage of FAST sync in Acceptance Tests #1047

Closed
RatanRSur opened this issue Jun 4, 2020 · 1 comment
Closed

Investigate coverage of FAST sync in Acceptance Tests #1047

RatanRSur opened this issue Jun 4, 2020 · 1 comment
Assignees
Labels

Comments

@RatanRSur
Copy link
Contributor

RatanRSur commented Jun 4, 2020

#384 exposed that some acceptance tests fail on circleci (though not locally on my machine) when --sync-mode=FULL is not set.

The previous default was FULL sync always so I assumed that there must be some acceptance tests that explicitly enabled fast sync in order to test that part of the code. However, I discovered that there isn't even a way to configure the sync mode, and so, all ATs were using FULL sync.

We need to spend some time investigating how/if we want fast sync coverage in the acceptance tests. There are other forms of testing we can rely on for fast sync, unit, integration, ethereum/hive, to name a few. We should just make this decision intentionally and then go forward with whatever we decide.

@timbeiko timbeiko added this to the Chupacabra Sprint 67 milestone Jun 18, 2020
@RatanRSur RatanRSur self-assigned this Jun 23, 2020
@RatanRSur
Copy link
Contributor Author

We only have one test for fast sync that's more involved than a unit test and that's in RunnerTest. We're going to rely more heavily on the hive fast sync tests going forward do there's no action item to write new fast sync test in besu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants