Default to fast sync for named networks #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
RatanRSur
force-pushed
the
fast-sync-default
branch
from
29f31aa
to
8405926
Compare
Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
…ortant Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
RatanRSur
added
the
breaking
shemnon
approved these changes
Jun 3, 2020
|
Did the acceptance tests expect dev to full sync not fast sync? |
|
They're only failing on circleci, looking into it now. |
Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
|
@shemnon yup, the ATs never actually made that they require full sync explicit. The recent commit makes it so. |
shemnon
approved these changes
Jun 4, 2020
RatanRSur
added
the
doc-change-required
bgravenorst
removed
the
doc-change-required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ratan Rai Sur ratan.r.sur@gmail.com
PR description
We consider the named network condition to be satisfied when
--networkis explicitly used OR when it isn't supplied but neither are--genesis-fileor--privacy-enabled