Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC call parameters do not accept input and data field simultaneously #6697

Closed
friedemannf opened this issue Mar 7, 2024 · 2 comments · Fixed by #6702
Closed

RPC call parameters do not accept input and data field simultaneously #6697

friedemannf opened this issue Mar 7, 2024 · 2 comments · Fixed by #6702

Comments

@friedemannf
Copy link
Contributor

friedemannf commented Mar 7, 2024

Hi!

#6094 introduced the option to provide the calldata via the input field instead of the deprecated data field. To remain compatible with chains that have not yet implemented the updated spec, the Chainlink node will set both fields, which is working fine with all other chains so far but fails on Besu due to the strict check in the aforementioned PR:

    if (input != null && data != null) {
      throw new IllegalArgumentException("Only one of 'input' or 'data' should be provided");
    }

Is there a specific resons why this check is this strict, or could it be relaxed to the following:

    if (input != null && data != null && !input.equals(data)) {
      throw new IllegalArgumentException("Only one of 'input' or 'data' should be provided");
    }
@macfarla
Copy link
Contributor

macfarla commented Mar 7, 2024

that seems reasonable @friedemannf - would you like to do a PR to make this change?

@friedemannf
Copy link
Contributor Author

@macfarla thank you! Created a PR here: #6702

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants