Transaction call object to accept both input and data field if equal #6702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…being set if equal Signed-off-by: Friedemann Fürst <friedemann.fuerst@smartcontract.com>
Signed-off-by: Friedemann Fürst <friedemann.fuerst@smartcontract.com>
friedemannf
changed the title
friedemannf
changed the title
Signed-off-by: Friedemann Fürst <friedemann.fuerst@smartcontract.com>
|
We might want to adjust the documentation here to specify this behavior: |
macfarla
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
LGTM. test cases make it clear. Thanks for your contribution @friedemannf
macfarla
added
the
doc-change-required
Thanks for this - added |
MASDXI
pushed a commit
to MASDXI/besu
that referenced
this pull request
Mar 13, 2024
…yperledger#6702) * relax JsonCallParameter constructor to allow for both input and data being set if equal Signed-off-by: Friedemann Fürst <friedemann.fuerst@smartcontract.com> * fix: format Signed-off-by: Friedemann Fürst <friedemann.fuerst@smartcontract.com> * add changelog entry Signed-off-by: Friedemann Fürst <friedemann.fuerst@smartcontract.com> --------- Signed-off-by: Friedemann Fürst <friedemann.fuerst@smartcontract.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: MASDXI <sirawitt42@gmail.com>
alexandratran
removed
the
doc-change-required
amsmota
pushed a commit
to Citi/besu
that referenced
this pull request
Apr 16, 2024
…yperledger#6702) * relax JsonCallParameter constructor to allow for both input and data being set if equal Signed-off-by: Friedemann Fürst <friedemann.fuerst@smartcontract.com> * fix: format Signed-off-by: Friedemann Fürst <friedemann.fuerst@smartcontract.com> * add changelog entry Signed-off-by: Friedemann Fürst <friedemann.fuerst@smartcontract.com> --------- Signed-off-by: Friedemann Fürst <friedemann.fuerst@smartcontract.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: amsmota <antonio.mota@citi.com>
amsmota
pushed a commit
to Citi/besu
that referenced
this pull request
Apr 16, 2024
…yperledger#6702) * relax JsonCallParameter constructor to allow for both input and data being set if equal Signed-off-by: Friedemann Fürst <friedemann.fuerst@smartcontract.com> * fix: format Signed-off-by: Friedemann Fürst <friedemann.fuerst@smartcontract.com> * add changelog entry Signed-off-by: Friedemann Fürst <friedemann.fuerst@smartcontract.com> --------- Signed-off-by: Friedemann Fürst <friedemann.fuerst@smartcontract.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: amsmota <antonio.mota@citi.com>
matthew1001
pushed a commit
to kaleido-io/besu
that referenced
this pull request
Jun 7, 2024
…yperledger#6702) * relax JsonCallParameter constructor to allow for both input and data being set if equal Signed-off-by: Friedemann Fürst <friedemann.fuerst@smartcontract.com> * fix: format Signed-off-by: Friedemann Fürst <friedemann.fuerst@smartcontract.com> * add changelog entry Signed-off-by: Friedemann Fürst <friedemann.fuerst@smartcontract.com> --------- Signed-off-by: Friedemann Fürst <friedemann.fuerst@smartcontract.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Most advanced CI tests are deferred until PR approval, but you could:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTestsPR description
#6094 introduced the option to provide the calldata via the input field instead of the deprecated data field. It also introduced a check that prevents both field from being set. This seems overly strict as it prevents clients from setting both fields to remain backward-compatible. This PR relaxes the check to only fail if both fields are set and they are not equal.
Fixed Issue(s)
fixes #6697