Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth_estimateGas does not respect the block parameter #7414

Closed
fab-10 opened this issue Jul 31, 2024 · 1 comment · Fixed by #7502
Closed

eth_estimateGas does not respect the block parameter #7414

fab-10 opened this issue Jul 31, 2024 · 1 comment · Fixed by #7502
Assignees
Labels
bug Something isn't working good first issue Good for newcomers RPC

Comments

@fab-10
Copy link
Contributor

fab-10 commented Jul 31, 2024

Description

As defined by the standard https://ethereum.github.io/execution-apis/api-documentation/ eth_estimateGas have a second optional parameter that specified the block to use for the estimation, we ignore that option and just use the chain head in every case.

Acceptance Criteria

eth_estimateGas adhere to the standard and accepts and uses the value passed in the block parameter to perform the estimation.

@fab-10 fab-10 added bug Something isn't working RPC labels Jul 31, 2024
@fab-10
Copy link
Contributor Author

fab-10 commented Jul 31, 2024

hint, many other RPC methods are already parsing and using that parameter, see AbstractBlockParameterMethod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers RPC
Projects
None yet
3 participants