Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor block number or tag parameter in eth_estimateGas and eth_createAccessList #7502

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

fab-10
Copy link
Contributor

@fab-10 fab-10 commented Aug 21, 2024

…AccessList

PR description

Fix to read and used the block tag or number parameter in eth_estimateGas and eth_createAccessList instead of always using the latest block.

Fixed Issue(s)

fixes #7414

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

…AccessList

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10 fab-10 force-pushed the eth_estimateGas-block-aware branch from b0f901d to 677f5ee Compare September 2, 2024 17:08
@fab-10 fab-10 marked this pull request as ready for review September 2, 2024 17:08
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10 fab-10 merged commit dad05d4 into hyperledger:main Sep 5, 2024
40 checks passed
@fab-10 fab-10 deleted the eth_estimateGas-block-aware branch September 5, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eth_estimateGas does not respect the block parameter
2 participants