Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove references and logic of system property besu.docker #785

Closed
usmansaleem opened this issue Apr 25, 2020 · 0 comments
Closed

Remove references and logic of system property besu.docker #785

usmansaleem opened this issue Apr 25, 2020 · 0 comments
Assignees
@usmansaleem
Labels
TeamGroot GH issues worked on by Groot Team

Comments

@usmansaleem
Copy link
Member

BesuCommand class (and related unit tests) has quite a bit of deprecated logic which sets various defaults depending on if system property besu.docker is present or not. However, this property is not set in Besu's docker file anymore. Hence, the relevant code needs to be removed.
@usmansaleem usmansaleem self-assigned this Apr 25, 2020
@usmansaleem usmansaleem mentioned this issue Apr 25, 2020
Merged
@usmansaleem usmansaleem added the TeamGroot GH issues worked on by Groot Team label Apr 28, 2020
@usmansaleem usmansaleem mentioned this issue Apr 29, 2020
Merged
usmansaleem added a commit that referenced this issue May 4, 2020
@usmansaleem
[#785] Remove references and logic of system property besu.docker (#808)
e8bd7ad 
- Updated BesuCommand class by removing deprecated usage of besu.docker system property. 
- Removed StandaloneCommand and moved the options back into BesuCommand.

Signed-off-by: Usman Saleem <usman@usmans.info>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@usmansaleem usmansaleem

Labels
TeamGroot GH issues worked on by Groot Team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@usmansaleem