Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle batch requests in WebSockets #1583

Merged
merged 7 commits into from
Nov 19, 2020
Merged

Conversation

macfarla
Copy link
Contributor

@macfarla macfarla commented Nov 18, 2020

Signed-off-by: Sally MacFarlane sally.macfarlane@consensys.net

Handle batched requests in WebSockets as for Http

Fixed Issue(s)

See #1564

Changelog

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Copy link
Member

@lucassaldanha lucassaldanha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It would be good to have some unit tests around handling invalid batch requests.

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
@macfarla macfarla merged commit 0dd90d0 into hyperledger:master Nov 19, 2020
@macfarla macfarla deleted the ws-batch branch November 19, 2020 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants