Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gradle to 6.0, support Java 13 #180

Merged
merged 4 commits into from
Nov 11, 2019

Conversation

shemnon
Copy link
Contributor

@shemnon shemnon commented Nov 9, 2019

Upgrade gradle to 6.0.

  • This is needed as Gradle 5.x did not support Java 13
  • Jacoco needed a version upgrade to support Java 13
  • upgrade errorprone to 1.1.1 to fix some breaks
  • Another errorprone check is broken in 13
  • The 'Finally' Errorprone check is only broken in Java 12

Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>

Upgrade gradle to 6.0.
* This is needed as Gradle 5.x did not support Java 13
* Jacoco needed a version upgrade to support Java 13
* upgrade errorprone to 1.1.1 to fix some breaks
* Another errorprone check is broken in 13
* The 'Finally' Errorprone check is only broken in Java 12

Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Copy link
Member

@lucassaldanha lucassaldanha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -2,4 +2,4 @@ distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-5.4.1-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-6.0-all.zip
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bin distribution?

Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>

# Conflicts:
#	build.gradle
@shemnon shemnon merged commit 5909678 into hyperledger:master Nov 11, 2019
@shemnon shemnon deleted the build_tweaks branch November 11, 2019 19:59
rain-on pushed a commit to rain-on/besu that referenced this pull request Nov 11, 2019
Upgrade Gradle to 6.0.
* This is needed as Gradle 5.x did not support Java 13
* Jacoco needed a version upgrade to support Java 13
* Upgrade Errorprone to fix some breaks
* Another Errorprone check is broken in 13
* The 'Finally' Errorprone check is only broken in Java 12
* JMH needed a version upgrade and a new build flag
* Switch to bin distribution for smaller builds

Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
rain-on pushed a commit to rain-on/besu that referenced this pull request Nov 11, 2019
Upgrade Gradle to 6.0.
* This is needed as Gradle 5.x did not support Java 13
* Jacoco needed a version upgrade to support Java 13
* Upgrade Errorprone to fix some breaks
* Another Errorprone check is broken in 13
* The 'Finally' Errorprone check is only broken in Java 12
* JMH needed a version upgrade and a new build flag
* Switch to bin distribution for smaller builds

Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Signed-off-by: Trent Mohay <trent.mohay@consensys.net>
siladu pushed a commit to siladu/besu that referenced this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants