Increase node diversity when downloading blocks #2033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
RatanRSur
reviewed
Mar 16, 2021
| LOG.debug("Downloading block {} from peers {}.", hash, peers.stream().map(EthPeer::toString)); | ||
| final Optional<EthPeer> peer = | ||
| peers.stream().filter(ethPeer -> !triedAndInvalidPeers.contains(ethPeer)).findFirst(); | ||
| if (peer.isPresent() && !peer.get().isDisconnected()) { |
There was a problem hiding this comment.
If even one peer is disconnected then we stop trying for others as well? I'm working on making this method simpler anyways, I'll show you my changes once I write them up.
There was a problem hiding this comment.
Just updated the code thanks to your PR. thanks
Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
…-block Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
RatanRSur
approved these changes
Mar 16, 2021
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
RichardH92
pushed a commit
to RichardH92/besu
that referenced
this pull request
Mar 29, 2021
Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Co-authored-by: Ratan Rai Sur <ratan.r.sur@gmail.com> Signed-off-by: Richard Hart <richardhart92@gmail.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Co-authored-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Karim TAAM karim.t2am@gmail.com
PR description
As a node operator, I don't want to see "Failed to download block 0xhex from peer 0xhex..." message from the same node over and over. I want to see besu fail over to another node and try again rather than failing from the same node
Tes performed
Changelog