Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignore privateFor for tx estimation #2160

Merged
merged 1 commit into from
Apr 20, 2021
Merged

ignore privateFor for tx estimation #2160

merged 1 commit into from
Apr 20, 2021

Conversation

macfarla
Copy link
Contributor

@macfarla macfarla commented Apr 19, 2021 •
edited
Loading

Signed-off-by: Sally MacFarlane sally.macfarlane@consensys.net

Related to #2125, private tx estimation passes the privateFor field eg

{"jsonrpc":"2.0","method":"eth_estimateGas","params":[{"from":"0x6402a0d7d3ed9db2163a234925e2bf82d45c7f99","gas":"0x47b760","value":"0x0","data":"0x608060405234801561001057600080fd5b5060405160208061011b8339810180604052602081101561003057600080fd5b505160005560d8806100436000396000f3fe6080604052348015600f57600080fd5b506004361060325760003560e01c806360fe47b11460375780636d4ce63c146053575b600080fd5b605160048036036020811015604b57600080fd5b5035606b565b005b605960a6565b60408051918252519081900360200190f35b60008190556040805182815290517f281b9a35503a0b511f50336e3e6b0d05a64fdadae7255e70f430feb2313c3c689181900360200190a150565b6000549056fea165627a7a7230582044f05a413bc5760ad1822322e6d8df2e38a8d78bb77512b03041026765408a1c0029","nonce":"0x0","privateFor":["FYmUrG0welC/cEm0buZsH9fjGeuETNZvZNeiROpy7XA="]}],"id":8}

Fixed Issue(s)

Changelog

@macfarla
ignore privateFor for private tx estimation
fe1f3aa 
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
@lucassaldanha lucassaldanha merged commit f973f95 into hyperledger:master Apr 20, 2021
@macfarla macfarla deleted the estimategas-ignore-privatefor branch April 20, 2021 02:34
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
@macfarla @eum602
ignore privateFor for private tx estimation (hyperledger#2160)
ba2ae42 
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucassaldanha lucassaldanha lucassaldanha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@macfarla @lucassaldanha