DSL precondition to avoid creating orphan processes #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 7, 2020 13:18
Signed-off-by: Christopher Hare <chris.hare@consensys.net>
Signed-off-by: Christopher Hare <chris.hare@consensys.net>
shemnon
approved these changes
Jan 9, 2020
AbdelStark
pushed a commit
to matkt/besu
that referenced
this pull request
Jan 9, 2020
Signed-off-by: Christopher Hare <chris.hare@consensys.net> Co-authored-by: Danno Ferrin <danno.ferrin@shemnon.com> Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>
AbdelStark
added a commit
that referenced
this pull request
Jan 9, 2020
* refactor nat manager Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * restart tests Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * restart tests Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * Add Tuweni to Plugin-APIs (#295) Generally, byte[] -> Bytes of some form. Most of the changes are the side effect of the type changes or chaning to the names of Tuweni equivilant calls (getHexString->toHexString, etc). UnformattedData -> Bytes Log Topics went from Hash to Bytes32 Difficulty went to UInt256 to match core impl. Quantity lost BinaryData and is just getValue() and toHexString() Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com> Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * DSL precondition to avoid creating orphan processes (#291) Signed-off-by: Christopher Hare <chris.hare@consensys.net> Co-authored-by: Danno Ferrin <danno.ferrin@shemnon.com> Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * Fix AT failure because of additional field sent by Orion (#299) Signed-off-by: Stefan Pingel <stefan.pingel@consensys.net> Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * Update NatService.java Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * Update NatServiceType.java Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * Update NatServiceType.java Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * Update NatServiceType.java Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * Update NatServiceType.java Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * remove method Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * SPDX-License-Identifier: Apache-2.0 Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * SPDX-License-Identifier: Apache-2.0 Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * Comment waitForFile: "besu.networks" Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * spotless apply Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * test Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * create file if not exist Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * remove useless code Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * fix waitForFile method Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Co-authored-by: Danno Ferrin <danno.ferrin@shemnon.com> Co-authored-by: CJ Hare <CjHare@users.noreply.github.com> Co-authored-by: pinges <16143240+pinges@users.noreply.github.com> Co-authored-by: Abdelhamid Bakhta <45264458+abdelhamidbakhta@users.noreply.github.com>
GregTheGreek
pushed a commit
to ChainSafe/besu
that referenced
this pull request
Feb 4, 2020
…ger#190 (hyperledger#298) * refactor nat manager Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * restart tests Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * restart tests Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * Add Tuweni to Plugin-APIs (hyperledger#295) Generally, byte[] -> Bytes of some form. Most of the changes are the side effect of the type changes or chaning to the names of Tuweni equivilant calls (getHexString->toHexString, etc). UnformattedData -> Bytes Log Topics went from Hash to Bytes32 Difficulty went to UInt256 to match core impl. Quantity lost BinaryData and is just getValue() and toHexString() Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com> Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * DSL precondition to avoid creating orphan processes (hyperledger#291) Signed-off-by: Christopher Hare <chris.hare@consensys.net> Co-authored-by: Danno Ferrin <danno.ferrin@shemnon.com> Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * Fix AT failure because of additional field sent by Orion (hyperledger#299) Signed-off-by: Stefan Pingel <stefan.pingel@consensys.net> Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * Update NatService.java Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * Update NatServiceType.java Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * Update NatServiceType.java Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * Update NatServiceType.java Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * Update NatServiceType.java Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * remove method Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * SPDX-License-Identifier: Apache-2.0 Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * SPDX-License-Identifier: Apache-2.0 Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * Comment waitForFile: "besu.networks" Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * spotless apply Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * test Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * create file if not exist Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * remove useless code Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * fix waitForFile method Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Co-authored-by: Danno Ferrin <danno.ferrin@shemnon.com> Co-authored-by: CJ Hare <CjHare@users.noreply.github.com> Co-authored-by: pinges <16143240+pinges@users.noreply.github.com> Co-authored-by: Abdelhamid Bakhta <45264458+abdelhamidbakhta@users.noreply.github.com>
edwardmack
pushed a commit
to ChainSafe/besu
that referenced
this pull request
Feb 4, 2020
Signed-off-by: Christopher Hare <chris.hare@consensys.net> Co-authored-by: Danno Ferrin <danno.ferrin@shemnon.com>
edwardmack
pushed a commit
to ChainSafe/besu
that referenced
this pull request
Feb 4, 2020
…ger#190 (hyperledger#298) * refactor nat manager Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * restart tests Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * restart tests Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * Add Tuweni to Plugin-APIs (hyperledger#295) Generally, byte[] -> Bytes of some form. Most of the changes are the side effect of the type changes or chaning to the names of Tuweni equivilant calls (getHexString->toHexString, etc). UnformattedData -> Bytes Log Topics went from Hash to Bytes32 Difficulty went to UInt256 to match core impl. Quantity lost BinaryData and is just getValue() and toHexString() Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com> Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * DSL precondition to avoid creating orphan processes (hyperledger#291) Signed-off-by: Christopher Hare <chris.hare@consensys.net> Co-authored-by: Danno Ferrin <danno.ferrin@shemnon.com> Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * Fix AT failure because of additional field sent by Orion (hyperledger#299) Signed-off-by: Stefan Pingel <stefan.pingel@consensys.net> Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * Update NatService.java Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * Update NatServiceType.java Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * Update NatServiceType.java Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * Update NatServiceType.java Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * Update NatServiceType.java Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * remove method Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * SPDX-License-Identifier: Apache-2.0 Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * SPDX-License-Identifier: Apache-2.0 Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * Comment waitForFile: "besu.networks" Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * spotless apply Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * test Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * create file if not exist Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * remove useless code Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * fix waitForFile method Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Co-authored-by: Danno Ferrin <danno.ferrin@shemnon.com> Co-authored-by: CJ Hare <CjHare@users.noreply.github.com> Co-authored-by: pinges <16143240+pinges@users.noreply.github.com> Co-authored-by: Abdelhamid Bakhta <45264458+abdelhamidbakhta@users.noreply.github.com>
edwardmack
pushed a commit
to ChainSafe/besu
that referenced
this pull request
Feb 4, 2020
Signed-off-by: Christopher Hare <chris.hare@consensys.net> Co-authored-by: Danno Ferrin <danno.ferrin@shemnon.com> Signed-off-by: edwardmack <ed@edwardmack.com>
edwardmack
pushed a commit
to ChainSafe/besu
that referenced
this pull request
Feb 4, 2020
…ger#190 (hyperledger#298) * refactor nat manager Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * restart tests Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * restart tests Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * Add Tuweni to Plugin-APIs (hyperledger#295) Generally, byte[] -> Bytes of some form. Most of the changes are the side effect of the type changes or chaning to the names of Tuweni equivilant calls (getHexString->toHexString, etc). UnformattedData -> Bytes Log Topics went from Hash to Bytes32 Difficulty went to UInt256 to match core impl. Quantity lost BinaryData and is just getValue() and toHexString() Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com> Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * DSL precondition to avoid creating orphan processes (hyperledger#291) Signed-off-by: Christopher Hare <chris.hare@consensys.net> Co-authored-by: Danno Ferrin <danno.ferrin@shemnon.com> Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * Fix AT failure because of additional field sent by Orion (hyperledger#299) Signed-off-by: Stefan Pingel <stefan.pingel@consensys.net> Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * Update NatService.java Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * Update NatServiceType.java Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * Update NatServiceType.java Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * Update NatServiceType.java Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * Update NatServiceType.java Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * remove method Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * SPDX-License-Identifier: Apache-2.0 Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * SPDX-License-Identifier: Apache-2.0 Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * Comment waitForFile: "besu.networks" Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * spotless apply Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * test Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * create file if not exist Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * remove useless code Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * fix waitForFile method Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Co-authored-by: Danno Ferrin <danno.ferrin@shemnon.com> Co-authored-by: CJ Hare <CjHare@users.noreply.github.com> Co-authored-by: pinges <16143240+pinges@users.noreply.github.com> Co-authored-by: Abdelhamid Bakhta <45264458+abdelhamidbakhta@users.noreply.github.com> Signed-off-by: edwardmack <ed@edwardmack.com>
siladu
pushed a commit
to siladu/besu
that referenced
this pull request
Oct 28, 2024
* wip * more wip * update contributor docs * add testing docs * few more updates * update main readme * fix spelling error * fix more spelling * fix line width for paragraph * rm extra new line * moar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Christopher Hare chris.hare@consensys.net
PR description
State check to ensure that the non-unique node name (the is being used as a key in a map) does not inadvertently orphan an existing process sharing the same name.
Fixed Issue(s)