Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 'to' field optional in eth_call method according to the spec #3177

Merged
merged 1 commit into from
Dec 17, 2021

Conversation

fab-10
Copy link
Contributor

@fab-10 fab-10 commented Dec 15, 2021

Signed-off-by: Fabio Di Fabio fabio.difabio@consensys.net

PR description

According to the spec, the 'to' field of a transaction is optional, and it is not specified when call eth_call to create a contract.

Fixed Issue(s)

fixes #3173

Changelog

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10 fab-10 marked this pull request as ready for review December 16, 2021 18:22
@sonarcloud
Copy link

sonarcloud bot commented Dec 16, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@garyschulte garyschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@fab-10 fab-10 merged commit 31261c9 into hyperledger:main Dec 17, 2021
@fab-10 fab-10 deleted the eth_call_to_optional branch December 17, 2021 21:05
gezero pushed a commit that referenced this pull request Jan 6, 2022
)

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10 fab-10 added the doc-change-required Indicates an issue or PR that requires doc to be updated label Jan 26, 2022
@bgravenorst bgravenorst removed the doc-change-required Indicates an issue or PR that requires doc to be updated label Mar 4, 2022
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
…perledger#3177)

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The transaction parameter 'to' should be optional in the 'eth_call' API
3 participants