Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checkpoint sync for merge #4085

Merged
merged 4 commits into from
Jul 15, 2022
Merged

checkpoint sync for merge #4085

merged 4 commits into from
Jul 15, 2022

Conversation

matkt
Copy link
Contributor

@matkt matkt commented Jul 12, 2022 •
edited
Loading

Signed-off-by: Karim TAAM karim.t2am@gmail.com

PR description

For the merge the block of the checkpoint must not be after the deployment of the deposit contract

Fixed Issue(s)

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if
    updates are required.

Changelog

@matkt
update checkpoint block for merge
d9b9986 
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
daniellehrner
daniellehrner approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@daniellehrner daniellehrner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

garyschulte
garyschulte approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@garyschulte garyschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

as an aside: it would be nice to be able to override the checkpoint params on the cli. right now we cannot have a map override type so we cannot override either the discovery or checkpoint config items

@matkt
Copy link
Contributor Author

matkt commented Jul 13, 2022 •
edited
Loading

I did a quick optimisation for the sync. if you can review it @garyschulte @daniellehrner

@matkt
Copy link
Contributor Author

matkt commented Jul 13, 2022 •
edited
Loading

result of my tests with this new checkpoint block on i3.2xlarge

  • 24 hours for mainnet
  • 3 hours 45 minutes for goerli

this new sync will be ready for the merge

daniellehrner
daniellehrner approved these changes Jul 14, 2022
View reviewed changes
Copy link
Contributor

@daniellehrner daniellehrner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

garyschulte
garyschulte approved these changes Jul 14, 2022
View reviewed changes
Copy link
Contributor

@garyschulte garyschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@iamhsk iamhsk added the TeamChupa GH issues worked on by Chupacabara Team label Jul 14, 2022
@matkt matkt marked this pull request as ready for review July 15, 2022 16:53
@matkt matkt enabled auto-merge (squash) July 15, 2022 16:53
@matkt matkt merged commit f885c46 into hyperledger:main Jul 15, 2022
codyborn pushed a commit to codyborn/besu that referenced this pull request Jul 31, 2022
@matkt @codyborn
Update checkpoint sync for merge (hyperledger#4085)
55099d0 
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
codyborn pushed a commit to codyborn/besu that referenced this pull request Jul 31, 2022
@matkt @codyborn
Update checkpoint sync for merge (hyperledger#4085)
21a7054 
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Cody Born <codyborn@outlook.com>
@matkt matkt deleted the feature/update-checkpoint-for-merge branch August 17, 2023 07:28
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
@matkt @eum602
Update checkpoint sync for merge (hyperledger#4085)
1b2f15f 
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniellehrner daniellehrner daniellehrner approved these changes

@garyschulte garyschulte garyschulte approved these changes

Assignees
No one assigned
Labels
mainnet TeamChupa GH issues worked on by Chupacabara Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@matkt @garyschulte @daniellehrner @iamhsk @macfarla