Add experimental config option to enable v5 discovery #4103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@consensys.net>
macfarla
reviewed
Jul 15, 2022
| @@ -30,6 +30,7 @@ public class NetworkingOptions implements CLIOptions<NetworkingConfiguration> { | |||
| private final String CHECK_MAINTAINED_CONNECTIONS_FREQUENCY_FLAG = | |||
| "--Xp2p-check-maintained-connections-frequency"; | |||
| private final String DNS_DISCOVERY_SERVER_OVERRIDE_FLAG = "--Xp2p-dns-discovery-server"; | |||
| private final String DISCOVERY_PROTOCOL_V5_ENABLED = "--Xv5-disc-enabled"; | |||
There was a problem hiding this comment.
non-blocking feedback - if we're not exactly matching what geth calls this option, I think I would prefer 'discovery' over 'disc'
There was a problem hiding this comment.
Agree, I just changed the option name
Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@consensys.net>
macfarla
approved these changes
Jul 15, 2022
codyborn
pushed a commit
to codyborn/besu
that referenced
this pull request
Jul 31, 2022
* Add experimental config option to enable v5 discovery Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@consensys.net> Co-authored-by: Gabriel Trintinalia <gabriel.trintinalia@consensys.net> Co-authored-by: Sally MacFarlane <sally.macfarlane@consensys.net>
codyborn
pushed a commit
to codyborn/besu
that referenced
this pull request
Jul 31, 2022
* Add experimental config option to enable v5 discovery Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@consensys.net> Co-authored-by: Gabriel Trintinalia <gabriel.trintinalia@consensys.net> Co-authored-by: Sally MacFarlane <sally.macfarlane@consensys.net> Signed-off-by: Cody Born <codyborn@outlook.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
* Add experimental config option to enable v5 discovery Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@consensys.net> Co-authored-by: Gabriel Trintinalia <gabriel.trintinalia@consensys.net> Co-authored-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gabriel Trintinalia gabriel.trintinalia@consensys.net
PR description
Add experimental config option to enable v5 discovery##
Fixed Issue(s)
fixes #4088
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog