Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

applies merge filtering to peers after 2 finalized #4124

Merged
merged 5 commits into from
Aug 2, 2022
Merged

applies merge filtering to peers after 2 finalized #4124

merged 5 commits into from
Aug 2, 2022

Conversation

jflo
Copy link
Contributor

@jflo jflo commented Jul 18, 2022

Signed-off-by: Justin Florentine justin+github@florentine.us

@jflo jflo requested a review from garyschulte July 18, 2022 19:21
@jflo jflo enabled auto-merge (squash) July 19, 2022 15:12
@garyschulte
Copy link
Contributor

Testing this in ropsten, I cannot get more than a single peer after the node has been up for over 20 minutes. Prior to merging this, the node had 100 peers.

If I revert the merge and restart the node I have 20 peers within 2 minutes. The logs seem to indicate good reasons for the disconnects, but 🤷 :

{"@timestamp":"2022-07-19T22:16:29,397","level":"DEBUG","thread":"nioEventLoopGroup-3-7","class":"MergePeerFilter","message":"Disconnecting peer with difficulty 0x00000000000000000000000000000000000000000000000000b70d39a21bd772, likely still on PoW chain","throwable":""}
{"@timestamp":"2022-07-19T22:16:57,000","level":"DEBUG","thread":"nioEventLoopGroup-3-2","class":"MergePeerFilter","message":"Disconnecting peer with difficulty 0x00000000000000000000000000000000000000000000000000b2e4497dd545c1, likely still on PoW chain","throwable":""}
{"@timestamp":"2022-07-19T22:17:26,117","level":"DEBUG","thread":"nioEventLoopGroup-3-9","class":"MergePeerFilter","message":"Disconnecting peer with difficulty 0x00000000000000000000000000000000000000000000000000b70d39a21bd772, likely still on PoW chain","throwable":""}
{"@timestamp":"2022-07-19T22:17:56,185","level":"DEBUG","thread":"nioEventLoopGroup-3-10","class":"MergePeerFilter","message":"Disconnecting peer with difficulty 0x00000000000000000000000000000000000000000000000000b70d3d9b309d93, likely still on PoW chain","throwable":""}
{"@timestamp":"2022-07-19T22:17:56,997","level":"DEBUG","thread":"nioEventLoopGroup-3-5","class":"MergePeerFilter","message":"Disconnecting peer with difficulty 0x00000000000000000000000000000000000000000000000000b2e4497dd545c1, likely still on PoW chain","throwable":""}
{"@timestamp":"2022-07-19T22:18:56,568","level":"DEBUG","thread":"nioEventLoopGroup-3-3","class":"MergePeerFilter","message":"Disconnecting peer with difficulty 0x00000000000000000000000000000000000000000000000000b70d418f517f64, likely still on PoW chain","throwable":""}
{"@timestamp":"2022-07-19T22:18:56,996","level":"DEBUG","thread":"nioEventLoopGroup-3-10","class":"MergePeerFilter","message":"Disconnecting peer with difficulty 0x00000000000000000000000000000000000000000000000000b2e4497dd545c1, likely still on PoW chain","throwable":""}
{"@timestamp":"2022-07-19T22:19:57,006","level":"DEBUG","thread":"nioEventLoopGroup-3-4","class":"MergePeerFilter","message":"Disconnecting peer with difficulty 0x00000000000000000000000000000000000000000000000000b2e4497dd545c1, likely still on PoW chain","throwable":""}
{"@timestamp":"2022-07-19T22:20:56,999","level":"DEBUG","thread":"nioEventLoopGroup-3-3","class":"MergePeerFilter","message":"Disconnecting peer with difficulty 0x00000000000000000000000000000000000000000000000000b2e4497dd545c1, likely still on PoW chain","throwable":""}
{"@timestamp":"2022-07-19T22:21:37,687","level":"DEBUG","thread":"vert.x-worker-thread-0","class":"MergePeerFilter","message":"have seen 3 finalized blocks","throwable":""}
{"@timestamp":"2022-07-19T22:21:57,001","level":"DEBUG","thread":"nioEventLoopGroup-3-8","class":"MergePeerFilter","message":"Disconnecting peer with difficulty 0x00000000000000000000000000000000000000000000000000b2e4497dd545c1, likely still on PoW chain","throwable":""}
{"@timestamp":"2022-07-19T22:22:57,005","level":"DEBUG","thread":"nioEventLoopGroup-3-7","class":"MergePeerFilter","message":"Disconnecting peer with difficulty 0x00000000000000000000000000000000000000000000000000b2e4497dd545c1, likely still on PoW chain","throwable":""}
{"@timestamp":"2022-07-19T22:23:57,007","level":"DEBUG","thread":"nioEventLoopGroup-3-10","class":"MergePeerFilter","message":"Disconnecting peer with difficulty 0x00000000000000000000000000000000000000000000000000b2e4497dd545c1, likely still on PoW chain","throwable":""}
{"@timestamp":"2022-07-19T22:24:57,013","level":"DEBUG","thread":"nioEventLoopGroup-3-5","class":"MergePeerFilter","message":"Disconnecting peer with difficulty 0x00000000000000000000000000000000000000000000000000b2e4497dd545c1, likely still on PoW chain","throwable":""}
{"@timestamp":"2022-07-19T22:25:08,750","level":"DEBUG","thread":"nioEventLoopGroup-3-7","class":"MergePeerFilter","message":"Disconnecting peer with difficulty 0x00000000000000000000000000000000000000000000000000b70d65314d0eb3, likely still on PoW chain","throwable":""}
{"@timestamp":"2022-07-19T22:25:57,008","level":"DEBUG","thread":"nioEventLoopGroup-3-2","class":"MergePeerFilter","message":"Disconnecting peer with difficulty 0x00000000000000000000000000000000000000000000000000b2e4497dd545c1, likely still on PoW chain","throwable":""}
{"@timestamp":"2022-07-19T22:26:23,384","level":"DEBUG","thread":"nioEventLoopGroup-3-6","class":"MergePeerFilter","message":"Disconnecting peer with difficulty 0x00000000000000000000000000000000000000000000000000b2e4497dd545c1, likely still on PoW chain","throwable":""}
{"@timestamp":"2022-07-19T22:26:57,018","level":"DEBUG","thread":"nioEventLoopGroup-3-7","class":"MergePeerFilter","message":"Disconnecting peer with difficulty 0x00000000000000000000000000000000000000000000000000b2e4497dd545c1, likely still on PoW chain","throwable":""}
{"@timestamp":"2022-07-19T22:27:45,753","level":"DEBUG","thread":"nioEventLoopGroup-3-3","class":"MergePeerFilter","message":"Disconnecting peer with difficulty 0x00000000000000000000000000000000000000000000000000b70d711cb031c2, likely still on PoW chain","throwable":""}
{"@timestamp":"2022-07-19T22:27:57,019","level":"DEBUG","thread":"nioEventLoopGroup-3-8","class":"MergePeerFilter","message":"Disconnecting peer with difficulty 0x00000000000000000000000000000000000000000000000000b2e4497dd545c1, likely still on PoW chain","throwable":""}
{"@timestamp":"2022-07-19T22:28:00,576","level":"DEBUG","thread":"vert.x-worker-thread-0","class":"MergePeerFilter","message":"have seen 4 finalized blocks","throwable":""}
{"@timestamp":"2022-07-19T22:28:57,013","level":"DEBUG","thread":"nioEventLoopGroup-3-10","class":"MergePeerFilter","message":"Disconnecting peer with difficulty 0x00000000000000000000000000000000000000000000000000b2e4497dd545c1, likely still on PoW chain","throwable":""}
{"@timestamp":"2022-07-19T22:29:57,075","level":"DEBUG","thread":"nioEventLoopGroup-3-5","class":"MergePeerFilter","message":"Disconnecting peer with difficulty 0x00000000000000000000000000000000000000000000000000b2e4497dd545c1, likely still on PoW chain","throwable":""}
{"@timestamp":"2022-07-19T22:30:58,041","level":"DEBUG","thread":"nioEventLoopGroup-3-5","class":"MergePeerFilter","message":"Disconnecting peer with difficulty 0x00000000000000000000000000000000000000000000000000b2e4497dd545c1, likely still on PoW chain","throwable":""}
{"@timestamp":"2022-07-19T22:31:57,026","level":"DEBUG","thread":"nioEventLoopGroup-3-8","class":"MergePeerFilter","message":"Disconnecting peer with difficulty 0x00000000000000000000000000000000000000000000000000b2e4497dd545c1, likely still on PoW chain","throwable":""}
{"@timestamp":"2022-07-19T22:32:57,024","level":"DEBUG","thread":"nioEventLoopGroup-3-1","class":"MergePeerFilter","message":"Disconnecting peer with difficulty 0x00000000000000000000000000000000000000000000000000b2e4497dd545c1, likely still on PoW chain","throwable":""}
{"@timestamp":"2022-07-19T22:33:57,028","level":"DEBUG","thread":"nioEventLoopGroup-3-7","class":"MergePeerFilter","message":"Disconnecting peer with difficulty 0x00000000000000000000000000000000000000000000000000b2e4497dd545c1, likely still on PoW chain","throwable":""}
{"@timestamp":"2022-07-19T22:34:24,622","level":"DEBUG","thread":"vert.x-worker-thread-0","class":"MergePeerFilter","message":"have seen 5 finalized blocks","throwable":""}
{"@timestamp":"2022-07-19T22:34:57,023","level":"DEBUG","thread":"nioEventLoopGroup-3-9","class":"MergePeerFilter","message":"Disconnecting peer with difficulty 0x00000000000000000000000000000000000000000000000000b2e4497dd545c1, likely still on PoW chain","throwable":""}
{"@timestamp":"2022-07-19T22:35:57,032","level":"DEBUG","thread":"nioEventLoopGroup-3-7","class":"MergePeerFilter","message":"Disconnecting peer with difficulty 0x00000000000000000000000000000000000000000000000000b2e4497dd545c1, likely still on PoW chain","throwable":""}
{"@timestamp":"2022-07-19T22:36:21,363","level":"DEBUG","thread":"nioEventLoopGroup-3-2","class":"MergePeerFilter","message":"Disconnecting peer with difficulty 0x00000000000000000000000000000000000000000000000000b70da8d4aae195, likely still on PoW chain","throwable":""}
{"@timestamp":"2022-07-19T22:36:57,034","level":"DEBUG","thread":"nioEventLoopGroup-3-4","class":"MergePeerFilter","message":"Disconnecting peer with difficulty 0x00000000000000000000000000000000000000000000000000b2e4497dd545c1, likely still on PoW chain","throwable":""}
{"@timestamp":"2022-07-19T22:37:47,457","level":"DEBUG","thread":"nioEventLoopGroup-3-4","class":"MergePeerFilter","message":"Disconnecting peer with difficulty 0x00000000000000000000000000000000000000000000000000b6e4a65cd57e6f, likely still on PoW chain","throwable":""}
{"@timestamp":"2022-07-19T22:37:57,033","level":"DEBUG","thread":"nioEventLoopGroup-3-2","class":"MergePeerFilter","message":"Disconnecting peer with difficulty 0x00000000000000000000000000000000000000000000000000b2e4497dd545c1, likely still on PoW chain","throwable":""}
{"@timestamp":"2022-07-19T22:38:57,054","level":"DEBUG","thread":"nioEventLoopGroup-3-3","class":"MergePeerFilter","message":"Disconnecting peer with difficulty 0x00000000000000000000000000000000000000000000000000b2e4497dd545c1, likely still on PoW chain","throwable":""}
{"@timestamp":"2022-07-19T22:39:57,043","level":"DEBUG","thread":"nioEventLoopGroup-3-10","class":"MergePeerFilter","message":"Disconnecting peer with difficulty 0x00000000000000000000000000000000000000000000000000b2e4497dd545c1, likely still on PoW chain","throwable":""}
{"@timestamp":"2022-07-19T22:40:48,897","level":"DEBUG","thread":"vert.x-worker-thread-0","class":"MergePeerFilter","message":"have seen 6 finalized blocks","throwable":""}
{"@timestamp":"2022-07-19T22:40:57,042","level":"DEBUG","thread":"nioEventLoopGroup-3-9","class":"MergePeerFilter","message":"Disconnecting peer with difficulty 0x00000000000000000000000000000000000000000000000000b2e4497dd545c1, likely still on PoW chain","throwable":""}

@jflo jflo disabled auto-merge July 20, 2022 19:15
@jflo jflo self-assigned this Jul 26, 2022
jflo added 2 commits July 29, 2022 12:03
@jflo
applies merge filtering to peers after 2 finalized
3b25a91 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
spotless and update from main
a8f5819 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@macfarla macfarla assigned pinges and unassigned pinges Aug 2, 2022
@macfarla macfarla requested a review from pinges August 2, 2022 00:34
@jflo jflo enabled auto-merge (squash) August 2, 2022 16:59
garyschulte
garyschulte approved these changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@garyschulte garyschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

subtle. 🚢

@jflo jflo merged commit e1c8eb7 into hyperledger:main Aug 2, 2022
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
@jflo @eum602
applies merge filtering to peers after 2 finalized (hyperledger#4124)
193d87d 
* applies merge filtering to peers after 2 finalized
* fixes logical error in handling status messages

Signed-off-by: Justin Florentine <justin+github@florentine.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garyschulte garyschulte garyschulte approved these changes

@pinges pinges Awaiting requested review from pinges

Assignees

@jflo jflo

Labels
mainnet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jflo @garyschulte @macfarla @pinges